From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD733C433EF for ; Thu, 7 Jul 2022 12:53:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235909AbiGGMxC (ORCPT ); Thu, 7 Jul 2022 08:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235853AbiGGMwp (ORCPT ); Thu, 7 Jul 2022 08:52:45 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C8DC23136E for ; Thu, 7 Jul 2022 05:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657198353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dUmFi8DZaDYcJf12L/Xx0NmEj/l0aTrBYJ3yxA0AGTs=; b=TYm9w2Wqa5vNOhdSik7C8xsbtahmiledO/OHKsSiqKuY9XT/iAAzwwY5H0RMy2VCdD0PK4 3CmXdonO4Bbrl4jN/ypEwZtANHNR7Uta8z6eBdix0NWZffPFbXKOURnQR3VsoJT6PJssEm Dn69XgOHv2vP/RlVQQyQ2/LQkLG4+Go= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-460-o2jcox1COZ-558705x74gw-1; Thu, 07 Jul 2022 08:52:30 -0400 X-MC-Unique: o2jcox1COZ-558705x74gw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E59A5395AFE3; Thu, 7 Jul 2022 12:52:29 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.37.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3C8E62026D64; Thu, 7 Jul 2022 12:52:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20220707045112.10177-1-xiubli@redhat.com> <20220707045112.10177-3-xiubli@redhat.com> To: Jeff Layton Cc: dhowells@redhat.com, xiubli@redhat.com, idryomov@gmail.com, marc.dionne@auristor.com, willy@infradead.org, keescook@chromium.org, kirill.shutemov@linux.intel.com, william.kucharski@oracle.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cachefs@redhat.com, vshankar@redhat.com Subject: Re: [PATCH v3 2/2] afs: unlock the folio when vnode is marked deleted MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2433376.1657198347.1@warthog.procyon.org.uk> Date: Thu, 07 Jul 2022 13:52:27 +0100 Message-ID: <2433377.1657198347@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jeff Layton wrote: > > + folio_unlock(*folio); > > + folio_put(*folio); > > Don't you also need this? > > *folio = NULL; It shouldn't need any of those three lines. David