From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756828AbdEKPXF (ORCPT ); Thu, 11 May 2017 11:23:05 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:41832 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932445AbdEKPXA (ORCPT ); Thu, 11 May 2017 11:23:00 -0400 X-AuditID: b6c32a2d-f792a6d0000055a1-fb-591481d07863 From: Bartlomiej Zolnierkiewicz To: SF Markus Elfring Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org, Tomi Valkeinen , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] omapfb: Use devm_kcalloc() in vrfb_probe() Date: Thu, 11 May 2017 17:22:54 +0200 Message-id: <2438676.F6TUoaB08n@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1672837.1nPA5UjCzD@amdc3058> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42LZdlhTU/dCo0ikwcdfBhbnO5czW2y9JW1x ou8Dq8XlXXPYLGYv6WexWD//FpsDm8fxG9uZPJpOtbN6fN4kF8AcxWWTkpqTWZZapG+XwJWx 5McW9oK7XBUPLixnbWA8yNHFyMkhIWAisXzOAhYIW0ziwr31bF2MXBxCAksZJXrO9zFDOJ8Z JWa9esMK03H/6H92iMRaRomubyfYQBJCAl8ZJdZv8QWx2QSsJCa2r2LsYuTgEBEwlfhzIgSk nhmk/ubEN8wgNcIC9hIdB8+D2SwCqhInVvxgArF5BTQlTt9rA7NFBbwktuxrB7M5BbQknj9r Y4GoEZT4MfkemM0sIC+xb/9UVghbR+LssXWMIMskBP6zSbw+cp8Z5AgJAVmJTQegTBeJK6+L IH4Rlnh1fAs7hC0l0d0xC8qeziix/bcExJjNjBKrdk+ASlhLHD5+EWoXn0Tv7ydMEDN5JTra hCBKPCTO/PrMDGE7SlxZ28cECas9jBITJkxhnMAoPwvJC7OQvDALyQsLGJlXMYqlFhTnpqcW mxYY6RUn5haX5qXrJefnbmIEpwwt3R2MXxZ4H2IU4GBU4uFVAKYSIdbEsuLK3EOMEhzMSiK8 L+uBQrwpiZVVqUX58UWlOanFhxilOViUxHnVV16LEBJITyxJzU5NLUgtgskycXBKNTDybnno YrtgY6HrpOjzfaLhline9zQ2sMzm2nVKzT/noDh39q/7v07cD0reUMx8wE08+PC7rCna823q DaM0WEsPx++aIGn7/2y96vr+Hzeq55tET7nokpvhlW39t2/JJXPlN0XN4mornVdx7dKsfdF8 gvE0j8504b+Sem6Gnw53s837wuBy44MSS3FGoqEWc1FxIgDpupSPFQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t9jQd0LjSKRBsd2K1qc71zObLH1lrTF ib4PrBaXd81hs5i9pJ/FYv38W2wObB7Hb2xn8mg61c7q8XmTXABzlJtNRmpiSmqRQmpecn5K Zl66rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwylvzYwl5wl6vi wYXlrA2MBzm6GDk5JARMJO4f/c8OYYtJXLi3nq2LkYtDSGA1o8Tr85PZIZyvjBI9veeZQarY BKwkJravYuxi5OAQETCV+HMiBKSGWWAto8T6DdtYQWqEBewlOg5C1LMIqEqcWPGDCcTmFdCU OH2vDcwWFfCS2LKvHczmFNCSeP6sjQVi2T5Gif6vO5khGgQlfky+xwJiMwvIS+zbP5UVwtaS WL/zONMERoFZSMpmISmbhaRsASPzKkau1ILi3PTcYqMCo02MwFjZdlgrYAdj07noQ4wCHIxK PLwSVSKRQqyJZcWVuYcYJTiYlUR4X9YDhXhTEiurUovy44tKc1KLDzGaAv00kVlKNDkfGMd5 JfGGJpZGJgZmZoZGBsZmSuK8EwK/RAgJpCeWpGanphakFsH0MXFwSjUwnum8sOZus3RH0aJ1 OndSzuYZn4qZ59f8o7BkZkdSbJyETV+TvRHzby4Vod2LFMpbrvlW1W4IevjfvOBPf5Gj5fe6 1kXdj8RXrSiI3WYWI5oiNdW5IVeyeIHPkj9zSu62fl50JHLNTv2HGS8nd7FMD34YJ3Is4oT2 h8V19z8c7ppgc2beS9drSizFGYmGWsxFxYkAqQMq3qsCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170511152256epcas5p44c3bc4f67563e91fdd7eecd96adb6142 X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-CMS-RootMailID: 20170426092018epcas4p343e69e32255faa796e7c55c3e89e40f2 X-RootMTR: 20170426092018epcas4p343e69e32255faa796e7c55c3e89e40f2 References: <4a7b1751-4319-4bde-cf26-2de2a4096c68@users.sourceforge.net> <1672837.1nPA5UjCzD@amdc3058> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, May 11, 2017 04:27:19 PM Bartlomiej Zolnierkiewicz wrote: > > @@ -358,11 +358,7 @@ static int __init vrfb_probe(struct platform_device *pdev) > > return PTR_ERR(vrfb_base); > > > > num_ctxs = pdev->num_resources - 1; > > - > > - ctxs = devm_kzalloc(&pdev->dev, > > - sizeof(struct vrfb_ctx) * num_ctxs, > > - GFP_KERNEL); > > - > > + ctxs = devm_kcalloc(&pdev->dev, num_ctxs, sizeof(*ctxs), GFP_KERNEL); > > This change makes the resulting binary larger by 24 bytes (probably > because of the need to have an additional function argument) and 24 bytes seemed too much for just an additional function argument so I've checked the source: static inline void *devm_kzalloc(struct device *dev, size_t size, gfp_t gfp) { return devm_kmalloc(dev, size, gfp | __GFP_ZERO); } static inline void *devm_kmalloc_array(struct device *dev, size_t n, size_t size, gfp_t flags) { if (size != 0 && n > SIZE_MAX / size) return NULL; return devm_kmalloc(dev, n * size, flags); } static inline void *devm_kcalloc(struct device *dev, size_t n, size_t size, gfp_t flags) { return devm_kmalloc_array(dev, n, size, flags | __GFP_ZERO); } The extra kcalloc() checks are inlined currently into each instance. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics