From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB2043921CD for ; Mon, 4 May 2026 10:08:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889342; cv=none; b=XZofaJjRehadcAoQn/0yVeS1nr6PJuHwejXUy4rbO1d+8eGcbzur/joSAPFFTLmXtoO8kY9bIlfBwqm0LJ/YVHXCyV+mLxgoOltqKHCs7a4PY62k5ynOq8IeVHMqXIifu/5moUgBQpb6H4KalcovMBs+l1Gz5qteoRl4uc8Gv3I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777889342; c=relaxed/simple; bh=pcbrlB3qHsPLc/y90rnx1LrG5b7iFx58tWFuf97lMZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eEzaCCc1lygyZKmI0cCRSgMczVoAqUupheHpwO0HFH5CrVMDiXAbl0BOuXA/uXCJ54+lkI/LUPU9pDuRkPn1vbFjGWCb2DAVN3aofbFrW6I3WdtDHS5PFxr2blcd29I0ced8n2nkXHQLnnIUmcmXSIzvsUGBBCF8tu/k06ug53s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cKW7JyjX; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cKW7JyjX" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-393a49d2e5eso4819831fa.2 for ; Mon, 04 May 2026 03:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777889335; x=1778494135; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fUsuLRSeuIGkFfh6WNuAvk/R1MMvm5m1C1zWcRocwNE=; b=cKW7JyjXHGgh6mBa2l2a8jd40EAX5sw0SGAXxqQFYZFMqJLhudJJTojaBfnSJUqbOj w5BjRfybVM9L6dC7Jn/+Fkr4jsvL2/n2vqEB2P7MnRuuvnPtdWQzhptnWBVXuNYPbuap QOJY22o9bjxeYQ/k7Ftl21S5SQ1yv2kvkR9XDaWmQ+OhGLe/1p1jd9Cvc76vGcZa4TVq ZXdrTu0iXq7rlQK6IXjslucJviAi+WgrTlB31XjBOeAUXeJmsfXDuilGkZhliM4+ZHmW a/LNpYwKlfvwxDEX4MWlQRzxFzDLQPJ6R5LzP0Vjdc6prrrAnhzAaLdwOo1bmt5U1+0P STxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777889335; x=1778494135; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fUsuLRSeuIGkFfh6WNuAvk/R1MMvm5m1C1zWcRocwNE=; b=avDWYPVb4LiQzrHEUxgS2i/oRIgBRxHLjmtMfAqEdD+VUUk2KEIln8pLe71DdZ6qu3 QfANHSmy+CLqWM3vYaiY9Sw1J5xarBn2nkyZJUGwRyzb6qAQh69oNZq9QhIArAYjuPfJ zMxIIWE64yA3WzyF/P51KFKqnPox1d4XdbjAY4aBXSUek4VP2iMFu3af7zBXFjAM6lmK nS3mIeuzTJ1/HL7nzK+K/49nTvK0dhxMSaSL4KmF1ODmeBounhhb01MtIEirQKyvx+jM ztpz65j6TXi7zEhstO3T7UgUsg74W3bGXLhllJtiahDQmxXL67rdBbqua8luCfX5rKLi ItUg== X-Gm-Message-State: AOJu0YygnnHeXASPYogtOPBspGCZ34aWclfxKW1FJe1oLmyt/Dy/XGdi AQhidR3ARHpsjGrBO0paqI/lN1M+xbn+bsZLvHYi0MD5XfHuss9XWB7uM7NnbfY4p6i4+JT0dWk = X-Gm-Gg: AeBDies9hTzFavCkIMMqDCdZAgxphslm2k1wuC/Zma768vSnSz8ij7c0LojXXg3Rspj evpNgQxG8lSciMkIwf/FJK/WNRpxGBgMHSEGVUiX47c2J81v7b/5L8CJtWCF08JnSUo080twJIj qD9dMSky/lo3EVs7BGzgaStdrCcIGQTJf81Ei8dFR9t9oEKaQKLejTrxh7MD8sC1R0wgIeIsKUw zC19QYEMY46LmuR1/aiHyA32AsTHF6PHGcFZlb1rUO3Th5R4NgUhYr+XOlVEdxtdc9L6T+sm6sm iqwYw2jFb8uS6jGnA21/lLNMBXL/2SipluPMVKoIqQBiWqL1GoxwvHH97vHIpsdX2hdppnIuvet gZfTTgJgcCGNUx3NFXxVjl+3Th87I8ItHs7goiEQWN06Obu6iPR6OIITSpDDpjyvDghScxKOL50 CttmQtflTzQfbjuzcLya5xHKaXveyoYR83bErz2/MCX4WtidwnlIG4pXayVVvCCuc4r0/zcss= X-Received: by 2002:a05:6512:3c8a:b0:5a8:6ba2:225a with SMTP id 2adb3069b0e04-5a86ba22265mr1869874e87.39.1777889335210; Mon, 04 May 2026 03:08:55 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a86645ae7csm1979099e87.79.2026.05.04.03.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 May 2026 03:08:54 -0700 (PDT) From: Vastargazing To: linux-kernel@vger.kernel.org Cc: Vastargazing , stable@vger.kernel.org, Will Deacon , Mark Rutland , Jeremy Linton , Sudeep Holla , Lorenzo Pieralisi , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org Subject: [PATCH 4/5] perf: arm: pmu: fix reference leak on failed device registration Date: Mon, 4 May 2026 13:08:46 +0300 Message-ID: <243cb3737b41fae32a09117c17809a210395e69f.1777889235.git.vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When platform_device_register() fails in arm_acpi_register_pmu_device(), the embedded struct device has already been initialized by device_initialize() inside platform_device_register(). The error path unregisters the GSI interrupt but returns without dropping the device reference: arm_acpi_register_pmu_device() -> platform_device_register(pdev) -> device_initialize(&pdev->dev) /* kref = 1 */ -> platform_device_add(pdev) /* fails */ <- acpi_unregister_gsi() called, but kref still 1 Per platform_device_register() kernel-doc: NOTE: _Never_ directly free @pdev after calling this function, even if it returned an error! Always use platform_device_put() to give up the reference initialised in this function instead. Fix this by calling platform_device_put() in the error branch before unregistering the GSI. Fixes: d24a0c7099b3 ("arm_pmu: acpi: spe: Add initial MADT/SPE probing") Cc: stable@vger.kernel.org Assisted-by: GitHub Copilot (Claude Sonnet 4.5) Signed-off-by: Vastargazing --- drivers/perf/arm_pmu_acpi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/perf/arm_pmu_acpi.c b/drivers/perf/arm_pmu_acpi.c index e80f76d95e68..c2defbc32ad9 100644 --- a/drivers/perf/arm_pmu_acpi.c +++ b/drivers/perf/arm_pmu_acpi.c @@ -119,8 +119,10 @@ arm_acpi_register_pmu_device(struct platform_device *pdev, u8 len, pdev->resource[0].start = irq; ret = platform_device_register(pdev); - if (ret) + if (ret) { + platform_device_put(pdev); acpi_unregister_gsi(gsi); + } return ret; } -- 2.51.0