From: Andrew Lunn <andrew@lunn.ch>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next-next] net: phy: realtek: add support for rtl8224 2.5Gbps PHY
Date: Tue, 11 Jun 2024 15:21:05 +0200 [thread overview]
Message-ID: <243d5e27-522d-408d-a551-d11073cf330b@lunn.ch> (raw)
In-Reply-To: <20240611053415.2111723-1-chris.packham@alliedtelesis.co.nz>
On Tue, Jun 11, 2024 at 05:34:14PM +1200, Chris Packham wrote:
> The Realtek RTL8224 PHY is a 2.5Gbps capable PHY. It only uses the
> clause 45 MDIO interface and can leverage the support that has already
> been added for the other 822x PHYs.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
You probably should Cc: Eric Woudstra and Marek Behún who have both
worked on 2.5G variants of this PHY.
> Notes:
> I'm currently testing this on an older kernel because the board I'm
> using has a SOC/DSA switch that has a driver in openwrt for Linux 5.15.
> I have tried to selectively back port the bits I need from the other
> rtl822x work so this should be all that is required for the rtl8224.
>
> There's quite a lot that would need forward porting get a working system
> against a current kernel so hopefully this is small enough that it can
> land while I'm trying to figure out how to untangle all the other bits.
I don't see this as being a problem. It should not be possible to
cause regressions by adding a new device like this. If it turns out to
be broken, you can fix it up later.
Andrew
next prev parent reply other threads:[~2024-06-11 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 5:34 Chris Packham
2024-06-11 13:21 ` Andrew Lunn [this message]
2024-06-11 20:41 ` Chris Packham
2024-06-11 20:42 ` Chris Packham
2024-06-12 7:07 ` Marek Behún
2024-06-12 20:39 ` Chris Packham
2024-06-14 8:18 ` Paolo Abeni
2024-06-14 8:25 ` Marek Behún
2024-06-16 21:24 ` Chris Packham
2024-06-17 8:12 ` Marek Behún
2024-06-15 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=243d5e27-522d-408d-a551-d11073cf330b@lunn.ch \
--to=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®