From: Marc Dietrich <marvin24@gmx.de>
To: Mark Zhang <nvmarkzhang@gmail.com>
Cc: Alexandre Courbot <acourbot@nvidia.com>,
Thierry Reding <thierry.reding@avionic-design.de>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Mark Zhang <markz@nvidia.com>,
gnurou@gmail.com
Subject: Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver
Date: Mon, 21 Jan 2013 09:52:45 +0100 [thread overview]
Message-ID: <2440319.UsvGAcXXBp@fb07-iapwap2> (raw)
In-Reply-To: <50FCEFDE.8000705@gmail.com>
Hi,
> > diff --git a/drivers/video/backlight/pwm_bl_tegra.c
> > b/drivers/video/backlight/pwm_bl_tegra.c new file mode 100644
> > index 0000000..8f2195b
> > --- /dev/null
> > +++ b/drivers/video/backlight/pwm_bl_tegra.c
>
> So according to the filename, I think we can put all tegra boards codes
> here, right? Just like what you do for Ventana, if I wanna add support
> for cardhu, I can define similar functions -- let's say "init_cardhu",
> "exit_cardhu", "notify_cardhu" and "notify_after_cardhu", right?
>
> But I think if we do in this way, the file will become very long soon.
> And there are a lot of redundant codes in it. So do you have any
> suggestions?
I think we (for PAZ00) will just reuse the ventana code which is sufficient
for us. But adding "pwm-backlight-ventana" to our DTS may look a bit strange.
On the other hand, I guess that's why the property is called "compatible".
Marc
next prev parent reply other threads:[~2013-01-21 8:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-19 10:30 [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support Alexandre Courbot
2013-01-19 10:30 ` [PATCH 1/3] pwm-backlight: add subdriver mechanism Alexandre Courbot
2013-01-19 10:30 ` [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver Alexandre Courbot
2013-01-21 7:35 ` Mark Zhang
2013-01-21 8:24 ` Alex Courbot
2013-01-21 8:35 ` Mark Zhang
2013-01-21 8:52 ` Marc Dietrich [this message]
2013-01-21 8:55 ` Mark Zhang
2013-01-21 17:46 ` Stephen Warren
2013-01-22 3:24 ` Alex Courbot
2013-01-22 7:06 ` Thierry Reding
2013-01-23 9:45 ` Alex Courbot
2013-01-24 6:10 ` Alex Courbot
2013-01-22 16:30 ` Stephen Warren
2013-01-23 10:15 ` Leela Krishna Amudala
2013-01-23 10:29 ` Alex Courbot
2013-01-19 10:30 ` [PATCH 3/3] tegra: ventana: of: add host1x device to DT Alexandre Courbot
2013-01-20 3:38 ` [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support Mark Zhang
2013-01-20 5:26 ` Alexandre Courbot
2013-01-20 5:51 ` Mark Zhang
2013-01-21 2:09 ` Mark Zhang
2013-01-21 2:59 ` Mark Zhang
2013-01-21 7:49 ` Thierry Reding
2013-01-21 8:18 ` Alex Courbot
2013-01-22 7:17 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2440319.UsvGAcXXBp@fb07-iapwap2 \
--to=marvin24@gmx.de \
--cc=acourbot@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=markz@nvidia.com \
--cc=nvmarkzhang@gmail.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®