From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753918AbcEIXzc (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 May 2016 19:55:32 -0400
Received: from cloudserver094114.home.net.pl ([79.96.170.134]:63588 "HELO
	cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with SMTP id S1753534AbcEIXza (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 May 2016 19:55:30 -0400
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Steve Muckle <steve.muckle@linaro.org>
Cc: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Linux PM list <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset
Date: Tue, 10 May 2016 01:58:47 +0200
Message-ID: <2440649.iyOucdARxJ@vostro.rjw.lan>
User-Agent: KMail/4.11.5 (Linux/4.5.0-rc1+; KDE/4.11.5; x86_64; ; )
In-Reply-To: <20160509235316.GA30310@sky.smuckle.net>
References: <6282396.VVEdgVYxO3@vostro.rjw.lan> <20160507063051.GA23722@gmail.com> <20160509235316.GA30310@sky.smuckle.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="utf-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, May 09, 2016 04:53:16 PM Steve Muckle wrote:
> On Sat, May 07, 2016 at 08:30:51AM +0200, Ingo Molnar wrote:
> > 
> > * Peter Zijlstra <peterz@infradead.org> wrote:
> > 
> > > On Fri, May 06, 2016 at 02:58:43PM +0200, Rafael J. Wysocki wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > > 
> > > > Commit 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization
> > > > update callbacks) overlooked the fact that update_load_avg(), where
> > > > CFS invokes cpufreq utilization update hooks, becomes an empty stub for
> > > > CONFIG_SMP unset.  In consequence, if CONFIG_SMP is not set, cpufreq
> > > > governors are never invoked from CFS and they do not have a chance to
> > > > evaluate CPU performace levels and update them often enough.  Needless
> > > > to say, things don't work as expected then.
> > > > 
> > > > Fix the problem by making the !CONFIG_SMP stub of update_load_avg()
> > > > invoke cpufreq update hooks too.
> > > > 
> > > > Fixes: 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization update callbacks)
> > > > Reported-by: Steve Muckle <steve.muckle@linaro.org>
> > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > 
> > > Rafael; feel free to push this through the pm tree.
> > > 
> > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > 
> > I already have it in sched/urgent.
> 
> Looks like this just missed 4.6-rc7 and the release email for
> that doesn't suggest an rc8, as it stands...

But the final 4.6 will be released on Sunday or so and there are a few days
left still.