mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael Kerrisk" <michael.kerrisk@gmx.net>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: akpm@osdl.org, mtk-lkml@gmx.net, alan@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix missing wakeup in ipc/sem
Date: Fri, 10 Dec 2004 13:41:58 +0100 (MET)	[thread overview]
Message-ID: <24417.1102682518@www4.gmx.net> (raw)
In-Reply-To: <41B898F8.6060500@colorfullife.com>

Manfred,

> My patch that removed the spin_lock calls from the tail of
> sys_semtimedop introduced a bug:
> Before my patch was merged, every operation that altered an array called
> update_queue. That call woke up threads that were waiting until a
> semaphore value becomes 0. I've accidentially removed that call.
> 
> The attached patch fixes that by modifying update_queue: the function
> now loops internally and wakes up all threads. The patch also removes
> update_queue calls from the error path of sys_semtimedop: failed
> operations do not modify the array, no need to rescan the list of
> waiting threads.

Thanks -- tested on 2.6.10-rc3 and it works for me.

Cheers,

Michael

-- 
GMX ProMail mit bestem Virenschutz http://www.gmx.net/de/go/mail
+++ Empfehlung der Redaktion +++ Internet Professionell 10/04 +++

      reply	other threads:[~2004-12-10 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-09 15:59 System V semaphore bug in kernel 2.6 Michael Kerrisk
2004-12-09 17:25 ` Manfred Spraul
2004-12-09 18:27 ` [PATCH] fix missing wakeup in ipc/sem Manfred Spraul
2004-12-10 12:41   ` Michael Kerrisk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24417.1102682518@www4.gmx.net \
    --to=michael.kerrisk@gmx.net \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=mtk-lkml@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome