From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E3E81DF277 for ; Fri, 13 Dec 2024 11:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734090904; cv=none; b=eMnB0XikGZr+tXv+iEbtDseo742I6zlthYSJKS7c6nIJolJ7sPi+AYOOJMmeRrBEHHyBVUTRT9cvfgCJE3jspeEWr2ulHXppN8AaC7jQ69+TuJME4vmUVAsHznkmX9qzfoW/DD2+Xb0f5ieoakRmxOKR3ZMamC94mdzY9ywchL0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734090904; c=relaxed/simple; bh=cm5icUi+sGrOEhIGQ1zzIb3GehhAkBun86ehhroxOkk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dBJ8VNJfhvE23lFu0MyEOm8pcqNKzLAa5Zfqwgpp6hI9moDhN0fjdSE/qKwW4h/gEwj+NLLKryq0VgTTdHMH/esVZ7PYBJdxn9WAUz9yX8UTsZUcwFDrpHIV7jYKnppzWNj2xhHowYUq60+Yd3FppS7dl0nYxS9+j3AsUvEWo0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=trhYqVBU; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="trhYqVBU" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-3003ae21db4so817761fa.1 for ; Fri, 13 Dec 2024 03:55:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734090901; x=1734695701; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2F3dU7OsF77ENdouZE5VjBEoGAwdDiEqe/G1nbxNLpk=; b=trhYqVBUkmMfN2kG1osEhNbww1Gu7a3EV34B339p4IRX8ZlczOWUX0peFPbWNbX1ia zLR32uEdDx099B852sbHC1XztZFJF3shiqZSXKexo5xEGmCDfbF0EuWTg5kibrpPrmw1 /EuVvxB2JmIhtBqY5fB4u0x6JdiK8o0umlnHGztn0qZMB1bLCaQ5BaaTw6xKoFXi/+p1 +2VR+Xy0m0IgVsWFNxdytgiLi44Bhuod1BY9V+PZ10WLEYPlWOjB1E5DKqbvf5YAVvdY 8+sw572STWXXcIACzgyO/uWPrrHLnU4B2M+W78Y8t0cngh7DWoxFnFDpHHfHJK8G/fC6 azOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734090901; x=1734695701; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2F3dU7OsF77ENdouZE5VjBEoGAwdDiEqe/G1nbxNLpk=; b=A41haXk5VIQwg9Pb3nucosr4g7JMSrqrZqQQH4R1yrKhxYYAtj4YJiIpC1rEaV4uXW DnPqvJmGpKn+hl7XHE9b8XPYuS850FrG0Ax7/UBleCJBJ4+2m82sqXfjIXrkOMRe/3EG bmjyuE/ghYOcLVloHGXpSkygpRegaiezCUrywNUvD1gZdt3Ju4eWZ3hyt8ovUidY/Gzr w30qozabUhiX6RTyANywLd0II7WiczE4gi76sIKhQlrVavtC9mGHNiNbBqSNYPdVFB+T wn7kEAyND7dC9Mj35KT/qO/JxXhqNRQXVF+LRfmvlDm8W7mtPCmY6dExgOtQY/yBWn33 sJZg== X-Forwarded-Encrypted: i=1; AJvYcCWbEyqV2e7++P30LsXEMWrhtMGiyOLFXCWzFbHq/elyZn8wu0bBW1EHzWf1FWVodfQJNGoAJSxOIRRHCoI=@vger.kernel.org X-Gm-Message-State: AOJu0YxgIGi1WT6/gWFqgZj2guFLC92yYfo4j+Xdjcl6f0FDiD5SKnIG xEDK60dKFJAeipEK1d8M61Kc2Ow7Ixii6idlsEHFBhwjuXOzGYAaBshegZAL1gs= X-Gm-Gg: ASbGncvu033QexzoSt+YEy52IowAwAQ4LPETnB+8rv+YMEg4+gMYo2/vizSy7n6NWzl rBh59un70v8mW7JrbV70pj030u6qg9NmOkGxaq8eyc+d9+1fNy0Su/7GUGb5oM7amieFqI1JGyo FyqaP9Zqivwwmjghoe7rx0zaff0u7LV7Ief1yFCrduAHsKw16k8kaXu7JNvyVcFX0Mq9e5nN3bh tquLYN7fO2AlkGkpEnhdJshlfjxaivoXPBBN4sO4D58PrZjmKslesumAf2zxA6KG5vXQqPif+hq pxaZT1oa2+E9HZ8KRnZi7pj45qVkU6PLLfA= X-Google-Smtp-Source: AGHT+IEw9CbAiCn1zybvAh6eWtC/7CZTeXbl9zppPNXp3e2y976kH/LkaKh1sfGg5XjVH3qSYyz7kw== X-Received: by 2002:a2e:b954:0:b0:2ff:bdef:88b5 with SMTP id 38308e7fff4ca-302544ca4b6mr2241771fa.12.1734090900693; Fri, 13 Dec 2024 03:55:00 -0800 (PST) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-302292959c0sm13482671fa.94.2024.12.13.03.54.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2024 03:55:00 -0800 (PST) Message-ID: <244ab38d-762f-4860-b38e-51b08389ee6a@linaro.org> Date: Fri, 13 Dec 2024 13:54:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property Content-Language: ru-RU To: Bryan O'Donoghue , Luca Weiss , Krzysztof Kozlowski Cc: Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Barnabas Czeman , AngeloGioacchino Del Regno , Caleb Connolly , David Heidelberg , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> <20241209-camss-dphy-v1-1-5f1b6f25ed92@fairphone.com> From: Vladimir Zapolskiy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/13/24 13:34, Bryan O'Donoghue wrote: > On 13/12/2024 11:24, Luca Weiss wrote: >> On Fri Dec 13, 2024 at 11:50 AM CET, Vladimir Zapolskiy wrote: >>> On 12/13/24 11:34, Krzysztof Kozlowski wrote: >>>> On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: >>>>> The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for >>>>> CSI-2, but not any others so restrict the bus-type property describing >>>>> this to the supported values. >>>>> >>>>> The only exception here is MSM8916 which only supports D-PHY. C-PHY was >>>>> introduced with newer SoCs. >>>>> >>>>> Do note, that currently the Linux driver only supports D-PHY. >>>>> >>>>> Signed-off-by: Luca Weiss >>>>> --- >>>>> .../bindings/media/qcom,msm8916-camss.yaml | 8 ++++++ >>>>> .../bindings/media/qcom,msm8953-camss.yaml | 15 +++++++++++ >>>>> .../bindings/media/qcom,msm8996-camss.yaml | 20 +++++++++++++++ >>>>> .../bindings/media/qcom,sc8280xp-camss.yaml | 20 +++++++++++++++ >>>>> .../bindings/media/qcom,sdm660-camss.yaml | 20 +++++++++++++++ >>>>> .../bindings/media/qcom,sdm845-camss.yaml | 20 +++++++++++++++ >>>>> .../bindings/media/qcom,sm8250-camss.yaml | 30 ++++++++++++++++++++++ >>>>> 7 files changed, 133 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml >>>>> index 9cc0a968a401836814560c1af3ee84d946500b4f..3de2a3d2b5b761106975aab65ff614b2ef579ef5 100644 >>>>> --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml >>>>> +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml >>>>> @@ -94,6 +94,10 @@ properties: >>>>> minItems: 1 >>>>> maxItems: 4 >>>>> >>>>> + bus-type: >>>>> + enum: >>>>> + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY >>>>> + >>>>> required: >>>>> - data-lanes >>>>> >>>>> @@ -113,6 +117,10 @@ properties: >>>>> minItems: 1 >>>>> maxItems: 4 >>>>> >>>>> + bus-type: >>>>> + enum: >>>>> + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY >>>>> + >>> >>> But is it really needed to specify the single supported bus-type? >>> >>> I believe it is not, at least it's not ever done for other media devices >>> like sensors. >> >> Through video-interfaces.yaml 'bus-type' is already allowed but not >> restricted to the values that actually make any sense on such hardware, >> so in my opinion this makes sense to have here. > This is additive not prescriptive. > > New additions should include this bus-type number as we will need it > when we add CPHY support and the subsequently move to the PHY API for > CAMSS PHYs. This particular reason is invalid IMO, since dtb changes are not relied on drivers and shall be kept agnostic. The open question is if it is really needed to specify non-variable bus-type property. As I've said it's not done for other media devices, so that's at least the established policy on practice. -- Best wishes, Vladimir