From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF873987D; Mon, 12 May 2025 12:24:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747052676; cv=none; b=nVC3C56dLASmGKSYJ84X6ixQprf7WdZ2QfXIEF/VmDgVEcxSpbPACEdDeFLOSiGvne+2wC7fgknhNinr4M5OQETwYtqY4+n2Xk8SC3Op0bt5LiUd7bMixuLVyNsew/FU/mnlOKAgwTJKgAhM6CFzPKeptyrZknj35GY4r1kVoEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747052676; c=relaxed/simple; bh=16F2gtICs4ZIAXeRn2Kvm9BI5xd2yTzYekJDClmF35Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NTeAz5EGoW4RnpdLff2BaaAnNhUDaq8fDSGpJMMV8/20f1ANAkG3TTTpjovmsHxVLMucilIWLy9tuDIXxLDIzsFoNxxRU8lA+ZePNxZXpHEOLzV4t2Noa95454ivuAQPyri2G48Z3EX+fpFmWiaRcSM6MD5hGl2eDR3yabPhvGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=cjsg+XTp; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="cjsg+XTp" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9zXfnbSppYVkiqJbjpkISDfr+gejKpHcxRUUf046aNk=; b=cjsg+XTph1oymI6oio60bnKYV6 5+ZK7uWPdA/GU7jDAsNX7NwYHWJR6IOr8V3B1p9rm1t9YFGCCSE7vNQvQuYgUY0ctp9aLboEmcQWe XDNPzYLQD09fKegTnAXQ3yQ9cAHpxUmOVf2WdeV0yoZ9iDx1Bv8iF4pcNt/GGGGTg20c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uESCl-00CKfj-Te; Mon, 12 May 2025 14:24:23 +0200 Date: Mon, 12 May 2025 14:24:23 +0200 From: Andrew Lunn To: zakkemble@gmail.com Cc: Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bcmgenet: tidy up stats, expose more stats in ethtool Message-ID: <244e2b38-b1bf-4632-afa1-acc018bb20dc@lunn.ch> References: <20250511214037.2805-1-zakkemble@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250511214037.2805-1-zakkemble@gmail.com> On Sun, May 11, 2025 at 10:40:36PM +0100, zakkemble@gmail.com wrote: > From: Zak Kemble > > This patch exposes more statistics counters in ethtool and tidies up the > counters so that they are all per-queue. The netdev counters are now only > updated synchronously in bcmgenet_get_stats instead of a mix of sync/async > throughout the driver. Hardware discarded packets are now counted in their > own missed stat instead of being lumped in with general errors. Hi Zak That sounds like a list. When i see a list in a commit message, i think the patch needs splitting up into smaller pieces. Andrew --- pw-bot: cr