mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Minwoo Im <minwoo.im@samsung.com>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Joel Granados <j.granados@samsung.com>,
	gost.dev@samsung.com, Asutosh Das <quic_asutoshd@quicinc.com>
Subject: Re: [PATCH] ufs: mcq: Fix missing argument 'hba' in MCQ_OPR_OFFSET_n
Date: Thu, 16 May 2024 08:03:17 -0600	[thread overview]
Message-ID: <2450470c-b449-48a7-9fb7-aa363cbe885b@acm.org> (raw)
In-Reply-To: <20240516031405.586706-1-minwoo.im@samsung.com>

On 5/15/24 21:14, Minwoo Im wrote:
>   /* Operation and runtime registers configuration */
>   #define MCQ_CFG_n(r, i)	((r) + MCQ_QCFG_SIZE * (i))
> -#define MCQ_OPR_OFFSET_n(p, i) \
> +#define MCQ_OPR_OFFSET_n(hba, p, i) \
>   	(hba->mcq_opr[(p)].offset + hba->mcq_opr[(p)].stride * (i))
Since inline functions are preferred over macros, please convert the
MCQ_OPR_OFFSET_n() macro into an inline function.

Thanks,

Bart.

  reply	other threads:[~2024-05-16 14:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240516032553epcas2p3b8f34d03f32cccccc628027fbe1e8356@epcas2p3.samsung.com>
2024-05-16  3:14 ` Minwoo Im
2024-05-16 14:03   ` Bart Van Assche [this message]
2024-05-19 20:39     ` Minwoo Im

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2450470c-b449-48a7-9fb7-aa363cbe885b@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=gost.dev@samsung.com \
    --cc=j.granados@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=minwoo.im@samsung.com \
    --cc=quic_asutoshd@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®