From: Valdis.Kletnieks@vt.edu
To: Nick Andrew <nick@nick-andrew.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v1 3/3] Sample refactor of socket.c to use recursive printk
Date: Sat, 06 Dec 2008 02:18:34 -0500 [thread overview]
Message-ID: <24518.1228547914@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Sat, 06 Dec 2008 18:00:23 +1100." <20081206070023.29149.92171.stgit@marcab.local.tull.net>
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
On Sat, 06 Dec 2008 18:00:23 +1100, Nick Andrew said:
> Sample refactor of socket.c to use recursive printk
I think we'd all appreciate it a lot if, instead of pointless code churn
in socket.c, you used it to fix an *actual* problem - like any of the
many places where we have issues with interleaved output in dmesg because
a function had to use 2 or 3 printk calls to build up a line.
In your 0/3 you point at sound/core/misc.c and drivers/cpufreq/cpufreq.c,
both of those would be better than socket.c
[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]
next prev parent reply other threads:[~2008-12-06 7:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-06 6:59 [RFC] Recursive printk Nick Andrew
2008-12-06 6:59 ` [RFC PATCH v1 1/3] Split the vsnprintf function into two parts Nick Andrew
2008-12-06 7:00 ` [RFC PATCH v1 2/3] Add %v support to vsnprintf() Nick Andrew
2008-12-06 17:27 ` Linus Torvalds
2008-12-06 7:00 ` [RFC PATCH v1 3/3] Sample refactor of socket.c to use recursive printk Nick Andrew
2008-12-06 7:03 ` David Miller
2008-12-06 7:18 ` Valdis.Kletnieks [this message]
2008-12-06 7:40 ` Nick Andrew
2008-12-06 7:20 ` [RFC] Recursive printk Andrew Morton
2008-12-06 7:33 ` Willy Tarreau
2008-12-06 7:41 ` Andrew Morton
2008-12-06 8:16 ` Willy Tarreau
2008-12-06 9:43 ` Takashi Iwai
2008-12-06 7:42 ` Joe Perches
2008-12-06 8:40 ` Nick Andrew
2008-12-06 9:11 ` Joe Perches
2008-12-06 23:16 ` Nick Andrew
2008-12-06 23:24 ` Linus Torvalds
2008-12-06 19:35 ` Al Viro
2008-12-06 8:30 ` Nick Andrew
2008-12-08 1:42 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24518.1228547914@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@nick-andrew.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®