From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756224AbcBCP15 (ORCPT ); Wed, 3 Feb 2016 10:27:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44600 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754985AbcBCP14 convert rfc822-to-8bit (ORCPT ); Wed, 3 Feb 2016 10:27:56 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1453318283.2858.27.camel@linux.vnet.ibm.com> References: <1453318283.2858.27.camel@linux.vnet.ibm.com> <20160119113026.23238.4498.stgit@warthog.procyon.org.uk> <20160119113041.23238.44728.stgit@warthog.procyon.org.uk> To: Mimi Zohar Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, petkan@mip-labs.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 02/20] KEYS: Add a system blacklist keyring [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24521.1454513272.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 03 Feb 2016 15:27:52 +0000 Message-ID: <24522.1454513272@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar wrote: > > (3) The ability to configure a list of blacklisted hashes into the kernel > > at build time. This is done by setting > > CONFIG_SYSTEM_BLACKLIST_HASH_LIST to the filename of a list of hashes > > that are in the form: > > > > "", "", ..., "" > > > > where each is a hex string representation of the hash and must > > include all necessary leading zeros to pad the hash to the right size. > > Is the output of "keyctl print" the hex string representation? No, there is no payload and no read method. "keyctl desc" will return the hex string representation. > Update keys documentation? Not a bad idea, but it should probably go in a separate document, along with info about asymmetric keys. > > The blacklist cannot currently be modified by userspace, but it will be > > possible to load it, for example, from the UEFI blacklist database. > > When loading the UEFI blacklist database is enabled, it should be > configurable. Probably. That patch isn't added yet though. > > In the future, it should also be made possible to load blacklisted > > asymmetric keys in here too. > > Please update to reflect patch 3/20 "X.509: Allow X.509 certs to be > blacklisted" adds this support. Changed to: A later commit will make it possible to load blacklisted asymmetric keys in here too. David