From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753111AbcB2Mwd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Feb 2016 07:52:33 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:64106 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752981AbcB2Mwb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Feb 2016 07:52:31 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Saeed Mahameed <saeedm@dev.mellanox.co.il>,
        Saeed Mahameed <saeedm@mellanox.com>, linux-rdma@vger.kernel.org,
        Linux Netdev List <netdev@vger.kernel.org>,
        Matan Barak <matanb@mellanox.com>, linux-kernel@vger.kernel.org,
        Leon Romanovsky <leonro@mellanox.com>,
        "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net/mlx5e: make VXLAN support conditional
Date: Mon, 29 Feb 2016 13:51:51 +0100
Message-ID: <2455934.lWxXaHB90g@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <CALzJLG8MG9y8yr7zi4UTED0FwgBTJ+_5vSSWHB5SHFs-e8WTbg@mail.gmail.com>
References: <1456521217-2174580-1-git-send-email-arnd@arndb.de> <CALzJLG8MG9y8yr7zi4UTED0FwgBTJ+_5vSSWHB5SHFs-e8WTbg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:go0E0gCOLtXzdzWlQbXFKFC74ncM5ODaXvjm87fLTXq10fOwhbx
 0K7ISOPcsclYyPbyzEeG20YrLFBMxtMLi7DQsGFRHdm0kPg+i2MxwpIe75keBAMkDaQqin3
 5LJ6TucDL7W98YDwOxSeBXmKeS5ti1uccHS5s4ZZBIdvw22e0wqis0xRJruswHmXuiVwi7P
 o0hybe6WzsV8LzdTVuDvg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:yfieKr/iQ7c=:n9R/F+KJEaAPGqTgEw/WNw
 gQ4dC5LTGd6Y37jw8s1L586tH66sDjsWJN8gMEdEqcJBCUSCretmhRDLOqg7Gb7H7blSGdUir
 2x1P5IuXnERgGaeL1YPaCjIsfeA4Xf7yXMp7tU3azZNWAwr48CQWDITQG/amGPilOmNT18sHO
 u7S3j87sv0zZCyTzPvj/Ga9eSKAUoyNybBUVMgEb3F8J07FAYR+HIiZMpx5WTA+34EcxjXmL+
 OfoWixKgro94Kso9FM50UztgTC6ShOJT0YbycU4si9ksavxXHCOdw4Zcs95NQqIuaWnLogfGv
 3h2DDm6l53V5v2iAy3KrZlstqbACkHuS3l/d7QYCVmwqHqYZ+zvCfGvvSyxbn+sIpbJFJubWL
 aqPmybfDLkrp0QQszGHyTzRJWBv7n4qL0U4z+K7jeDPn3z72UrLejyv9cUcRXrgnPDqD++AjS
 ZMC7caBrE8zrV8w9/Pr9lvraTc4dPd2aFeXIhpqY2aghK8aIswmT1R+DUvCs7pLaOOjtAJgT7
 VVDzgMqizT4hin/m3I5EPzDQYTT95rRrqPrHJyr9h2kZaTh+EbksuBcWNvxCQbg4MymfPz8GJ
 fsUr47jcFIGbxxNQ3vk7SZBw9CZHHPKM14icb64GuWsOwa+VGS6J/JFZhvnknUnXEMlTk0VME
 TMdvnoqvHtdywnBtjSGza5pM1Z6HG8N/0dpBfYeHX0Dre0V82dXXLZqMEAuzkJF5WBg1aCGm2
 FZAT+TCJwMwwz0C/
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday 28 February 2016 15:26:53 Saeed Mahameed wrote:
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > index 0d45f35aee72..44fc4bc35ffd 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> > @@ -2116,6 +2116,9 @@ static netdev_features_t mlx5e_vxlan_features_check(struct mlx5e_priv *priv,
> >         u16 proto;
> >         u16 port = 0;
> >
> > +       if (!IS_ENABLED(CONFIG_MLX5_CORE_EN_VXLAN))
> > +               goto out;
> > +
> 
> I would rather wrap the whole mlx5e_features_check with the suggested
> config flag and disable it in case CONFIG_MLX5_CORE_EN_VXLAN is OFF,
> since this function is only needed for when vxlan is supported.

Sounds good.

I think moving the IS_ENABLED() check into the caller(s) will still
result in the same object code, but it makes sense to structure
the code for best readability.

	Arnd