From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764044AbcIRUi1 (ORCPT ); Sun, 18 Sep 2016 16:38:27 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:61289 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759501AbcIRUiT (ORCPT ); Sun, 18 Sep 2016 16:38:19 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, davem@davemloft.net, yankejian@huawei.com, huangdaode@hisilicon.com, lipeng321@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h Date: Sun, 18 Sep 2016 22:37:29 +0200 Message-ID: <2457639.urVBpTjXKo@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1474189896-20417-1-git-send-email-baoyou.xie@linaro.org> References: <1474189896-20417-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:tU4ffYikzEDscS/r3EQ/lAOjHw+9cbI8MOPpViwBu2p1ykAOcH7 fIxCkNAKODcwBnzJDN1r6u38juotXhVq6taxucyQid3uM+HzdAt3m8LYh70he66AkZdyFbR 2ye/ZGJ5FMK8rv8hhatykCyGtH5rs5PdrCqO6uRDSWz/Lc9Zn/dM3P8rMr0p6a4tLs9rJa5 T6yQQCgtoUyzMkprY+4vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:8Nlg4ieJ/FI=:k5gvk5kpcBJqGzpxRCXMgW 7Q8jE0n2DsZoQ/frV41/m9qL66ifodmdoJaznrU0ps/rXxhrz5my8re9kSP2lFKE3LKDFL2Lw 0zNveX6AyqAMYbpJAt65+R3qKfvikXCyOcvM4ENY+QoEhEPJRo7ZuBtp1FlV6uLz6BXmHO+xg 6IVE1o1OjpV6cvjsYePv+SfwiqhGT+Ry9IUtJk9Vt8uyl5xXKPqCDY7lhnP/ajXbCITE8Buig JlNAhnEuDtOPg7ioY4OoF18MsZEzkqZiPUO2qdtexLG+0woLZchr3/+eX/6iSKtYAqYELLg1l AGLednWw80f+rG50QrBw06K6u9PNHG58gfL1RHS+3wYSvaUywxkk4lFESrcWVzo3oKKdqeS6x BYB0jpPQuh3diejxA3UTfxURaVY9eISJ3BYmUI4hQzcYlRGhqkTDdPwkWvAEGokk/pNa8xpk2 NevDlOgrVW3PQdzctV+FRqTOXXO6z6f5/MG5zVJGKvDuh+kWZ6O5fNk0RM1ajNKUsHn+oEJWa NbeSgs4qm3UEs3BtsoIp9DIWodK54Umm5rvpZvkebGt+qiJXoSi46mkxMzGdkRJWbZZchmgCJ JieRkUzghD0y+Y7df8Udh1pduCFi4XO3+9PMYuoGElqeqcOjquEx7NmMNSWdbBlq8aG8kDiVs TlLsGNJR2wivF+frm+YmLXgKq0nMO/fZ2SKZ4axnpuWSMo5nMnylYwwnsmQLRAKqpqMvpIATh 5qyzeEeKbugC9Jqj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, September 18, 2016 5:11:36 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes] > > In fact, these two functions are not declared in any file, but should > be declared in a header file, thus can be recognized in other file. > > So this patch adds the declarations into > drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h > > Signed-off-by: Baoyou Xie > Why can't these be declared static? Arnd