From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941440AbcIZMtn (ORCPT ); Mon, 26 Sep 2016 08:49:43 -0400 Received: from cloudserver094114.home.net.pl ([79.96.170.134]:45667 "HELO cloudserver094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933115AbcIZMtl (ORCPT ); Mon, 26 Sep 2016 08:49:41 -0400 From: "Rafael J. Wysocki" To: Hoan Tran Cc: Len Brown , pprakash@codeaurora.org, Ashwin Chaugule , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, lho@apm.com, Duc Dang Subject: Re: [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag Date: Mon, 26 Sep 2016 14:56:02 +0200 Message-ID: <2457650.luWgNvV3g9@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.8.0-rc2+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1473875698-12402-1-git-send-email-hotran@apm.com> References: <1473875698-12402-1-git-send-email-hotran@apm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 14, 2016 10:54:58 AM Hoan Tran wrote: > For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone() > function to notify the mailbox framework about TX completion. > > Signed-off-by: Hoan Tran > Reviewed-by: Prashanth Prakash > --- > drivers/acpi/cppc_acpi.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c > index 3d1ae6d..d0d0504 100644 > --- a/drivers/acpi/cppc_acpi.c > +++ b/drivers/acpi/cppc_acpi.c > @@ -311,7 +311,10 @@ static int send_pcc_cmd(u16 cmd) > if (pcc_data.pcc_mrtt) > last_cmd_cmpl_time = ktime_get(); > > - mbox_client_txdone(pcc_data.pcc_channel, ret); > + if (pcc_data.pcc_channel->mbox->txdone_irq) > + mbox_chan_txdone(pcc_data.pcc_channel, ret); > + else > + mbox_client_txdone(pcc_data.pcc_channel, ret); > > end: > if (cmd == CMD_WRITE) { > Applied. Thanks, Rafael