mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
	linux-cachefs@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()
Date: Thu, 12 Nov 2015 10:15:39 +0000	[thread overview]
Message-ID: <24593.1447323339@warthog.procyon.org.uk> (raw)
In-Reply-To: <1447282921-16352-1-git-send-email-geert@linux-m68k.org>

Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> -	int ret;
> +	int ret = 0;

This isn't quite the right solution.  The uninitialised error path needs to
set -ENOBUFS.  Unfortunately, my compiler doesn't show a warning:-/

David

  reply	other threads:[~2015-11-12 10:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 23:02 Geert Uytterhoeven
2015-11-12 10:15 ` David Howells [this message]
2015-11-12 10:23   ` Geert Uytterhoeven
2015-11-12 10:42   ` David Howells
2015-11-12 10:43     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24593.1447323339@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®