mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: zhouxianrong <zhouxianrong@huawei.com>
To: <linux-mm@kvack.org>
Cc: <akpm@linux-foundation.org>, <hughd@google.com>,
	<aarcange@redhat.com>, <kirill.shutemov@linux.intel.com>,
	<dave.hansen@linux.intel.com>, <zhouchengming1@huawei.com>,
	<geliangtang@163.com>, <linux-kernel@vger.kernel.org>,
	<zhouxiyu@huawei.com>, <wanghaijun5@huawei.com>
Subject: Re: [PATCH v2] more mapcount page as kpage could reduce total replacement times than fewer mapcount one in probability.
Date: Tue, 21 Jun 2016 09:57:54 +0800	[thread overview]
Message-ID: <2460b794-92f0-d115-c729-bcfe33663e48@huawei.com> (raw)
In-Reply-To: <1465955818-101898-1-git-send-email-zhouxianrong@huawei.com>

hey hugh:
     could you please give me some suggestion about this ?

On 2016/6/15 9:56, zhouxianrong@huawei.com wrote:
> From: z00281421 <z00281421@notesmail.huawei.com>
>
> more mapcount page as kpage could reduce total replacement times
> than fewer mapcount one when ksmd scan and replace among
> forked pages later.
>
> Signed-off-by: z00281421 <z00281421@notesmail.huawei.com>
> ---
>  mm/ksm.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/mm/ksm.c b/mm/ksm.c
> index 4786b41..4d530af 100644
> --- a/mm/ksm.c
> +++ b/mm/ksm.c
> @@ -1094,6 +1094,14 @@ static struct page *try_to_merge_two_pages(struct rmap_item *rmap_item,
>  {
>  	int err;
>
> +	/*
> +	 * select more mapcount page as kpage
> +	 */
> +	if (page_mapcount(page) < page_mapcount(tree_page)) {
> +		swap(page, tree_page);
> +		swap(rmap_item, tree_rmap_item);
> +	}
> +
>  	err = try_to_merge_with_ksm_page(rmap_item, page, NULL);
>  	if (!err) {
>  		err = try_to_merge_with_ksm_page(tree_rmap_item,
>

  reply	other threads:[~2016-06-21  2:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15  1:56 zhouxianrong
2016-06-21  1:57 ` zhouxianrong [this message]
2016-06-22  1:39   ` Hugh Dickins
2016-06-22 11:00     ` zhouxianrong
2016-07-20  1:03     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2460b794-92f0-d115-c729-bcfe33663e48@huawei.com \
    --to=zhouxianrong@huawei.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=geliangtang@163.com \
    --cc=hughd@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=wanghaijun5@huawei.com \
    --cc=zhouchengming1@huawei.com \
    --cc=zhouxiyu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®