From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12DAAEB64D7 for ; Wed, 21 Jun 2023 13:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232583AbjFUNiU (ORCPT ); Wed, 21 Jun 2023 09:38:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230226AbjFUNiR (ORCPT ); Wed, 21 Jun 2023 09:38:17 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C51EBE59 for ; Wed, 21 Jun 2023 06:38:16 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3E4855C01EE; Wed, 21 Jun 2023 09:38:16 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 21 Jun 2023 09:38:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1687354696; x=1687441096; bh=1d BRv88m8DzmsRCY2sdR5AtUmMT+gLlbjdNPhPq4Vr4=; b=yyYLrOekmAbDvkrI40 13wTo/99CDXoenIiXNlDedT/o823/dNHm8vCZ/KHY2BFkv8FJwVtaKEXPHYocrZ/ cXc+oAmavpuBDPszHzeS4VvdzQONA4eXJr9fBZoisuGxJeFULL8+++nracCCHHCn wh5ew3hK3F2WKsakvkhhgIXDHjrumvALKlSEBfpEtmXrfQSM8MiIzPiSrIdJHayE v4118BovNTCInZNKQFXSicMVtREPBMm9NWRt9OdBKcWBAIrIoM+Nu+820nDslL9I j/jhakcDl08RltP2o2RKJAYhIm8/61/8uD3yBJMLyLY8ktVD20wjl8HLokZOtO+z pjvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687354696; x=1687441096; bh=1dBRv88m8Dzms RCY2sdR5AtUmMT+gLlbjdNPhPq4Vr4=; b=QNWAj4DumqXhr/oHnIoKGkfN+sXCx MvJfP9/RYZNPp8VOW6DCfgEa/oASJYEeoF6Vns7aAXp8SI0knGIwNWMQSCySZcai ddcubxk1bosLygTf7pD1KWTm0QGZsNxe6PDMpdWf/QnThlRF6u8YcS9nXauRZgth 6kOkJnESxNl8ymdO2nZb7hyYKhMBp3UcqVdASxYfbZrkI7zyWC39QwclHbZOTPxK ba8GVLPyn95Z+V6Qez9pZUO52huxeCOmhQMlpHn7+bMWWMWOUvewP1sTXlHAA2MN +EJKIs2NY32pLMqJXl72QB2m9RhmSArpKdX7FgRJm24SI9ezoXJMO+w6A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefkedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepvefhffeltdegheeffffhtdegvdehjedtgfekueevgfduffettedtkeekueef hedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id F31DDB60086; Wed, 21 Jun 2023 09:38:15 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: <246274e5-851d-4cea-8e01-d165ebd967f9@app.fastmail.com> In-Reply-To: <168735222615.404.5437100914727545952.tip-bot2@tip-bot2> References: <168735222615.404.5437100914727545952.tip-bot2@tip-bot2> Date: Wed, 21 Jun 2023 15:37:55 +0200 From: "Arnd Bergmann" To: linux-kernel@vger.kernel.org Cc: "Marc Zyngier" , "Shawn Guo" , "Thomas Gleixner" Subject: Re: [irqchip: irq/irqchip-next] Revert "irqchip/mxs: Include linux/irqchip/mxs.h" Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 21, 2023, at 14:57, irqchip-bot for Marc Zyngier wrote: > The following commit has been merged into the irq/irqchip-next branch > of irqchip: > > Commit-ID: d93c22199966696cfb76c6942797de2fbb22da24 > Gitweb: > https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d93c22199966696cfb76c6942797de2fbb22da24 > Author: Marc Zyngier > AuthorDate: Wed, 21 Jun 2023 13:46:25 +01:00 > Committer: Marc Zyngier > CommitterDate: Wed, 21 Jun 2023 13:50:53 +01:00 > > Revert "irqchip/mxs: Include linux/irqchip/mxs.h" > > This reverts commit 5b7e5676209120814dbb9fec8bc3769f0f7a7958. > > Although including linux/irqchip/mxs.h is technically correct, > this clashes with the parallel removal of this include file > with 32bit ARM modernizing the low level irq handling as part of > 5bb578a0c1b8 ("ARM: 9298/1: Drop custom mdesc->handle_irq()"). > > As such, this patch is not only unnecessary, it also breaks > compilation in -next. Revert it. > > Signed-off-by: Marc Zyngier > Cc: Arnd Bergmann > Cc: Shawn Guo Thanks! I had prepared the same patch but not yet sent it as I was still debugging some unrelated issues. Once 5bb578a0c1b8 ends up in mainline, we can get back to fixing the warning by marking the handler as 'static'. Arnd