mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kepplinger <martink@posteo.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	kernel-testers@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes
Date: Tue, 28 Jun 2016 18:17:13 +0200	[thread overview]
Message-ID: <246597fa-6a85-1128-853d-3ebdf6f41032@posteo.de> (raw)
In-Reply-To: <20160623171835.GE32561@dtor-ws>

Am 2016-06-23 um 19:18 schrieb Dmitry Torokhov:
> Hi Martin,
> 
> On Tue, Jun 14, 2016 at 01:20:15PM +0200, Martin Kepplinger wrote:
>>  static int pegasus_reset_resume(struct usb_interface *intf)
>>  {
>> +	struct pegasus *pegasus = usb_get_intfdata(intf);
>> +
>> +	if (pegasus->dev->users)
>> +		pegasus_set_mode(pegasus, PEN_MODE_XY, NOTETAKER_LED_MOUSE);
>> +
>>  	return pegasus_resume(intf);
> 
> Hmm, we need to take input mutex when using pegasus->dev->users, how
> about the version below instead?
> 
> Thanks.
> 

Sorry for the delay, give me a few more days to test and confirm this or
come up with a final patch.

thanks
                            martin

  reply	other threads:[~2016-06-28 16:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-14 11:20 Martin Kepplinger
2016-06-14 11:37 ` Oliver Neukum
2016-06-15 13:01 ` [PATCH v9] input: tablet: add Pegasus Notetaker tablet driver Martin Kepplinger
2016-06-23 15:50   ` Martin Kepplinger
2016-06-23 17:18 ` [PATCH v2] input: tablet: pegasus_notetaker: USB PM fixes Dmitry Torokhov
2016-06-28 16:17   ` Martin Kepplinger [this message]
2016-07-08 21:08     ` Dmitry Torokhov
2016-07-09 12:07       ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=246597fa-6a85-1128-853d-3ebdf6f41032@posteo.de \
    --to=martink@posteo.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel-testers@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®