From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE223CAE94; Tue, 23 Jun 2026 08:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782202005; cv=none; b=sHmyPZ9SjmjK4yY8iFYayD/VS6FDMhTBtL6YXjiugFNuOCEHFobx9lvbuFrNtN7Lpf3otfCH9xD+Hqd36WRXavtliULUgaNQVXc+ox+uyO8XyR480wra1tBqSbWwsv8FYfoif92DoEIu9lvVFzykrl3/Rk0tYNScwmqG4Piyme4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782202005; c=relaxed/simple; bh=05sDxDxhH+7UoIrgdabJtlXr867z5VKROPNR6f1UT4I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eXLrJ0MrKP+qRrbgQAYW2FvHX04K95aqvSFDMbxGM8A4BGaRn9EsA6/8agWfJiT12i0ekjvhPNn4wIOk8AqzoOh0ZMcCHh1vwvoTQWAdkYoIOM15TGPsxls46ArMGkCXnUKRQvS815hW53y51IgoEBR++iz5apb6yAN2S1KvwdA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=owfJ3Ygz; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="owfJ3Ygz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1782202001; bh=05sDxDxhH+7UoIrgdabJtlXr867z5VKROPNR6f1UT4I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=owfJ3Ygz4Dlx/2o5TREY+3za/AJzA8mphrSFgVyPQoi9HTGiZZrHV2+/ej3XnEFZh +CTa6YjU6GHZzR4dtdFA1ZoPuNObDNh8ZH7kFeGjvHwsW4vGaG5sFY/a1caDLRQ5Z4 og32giKwkqQ7CGZ3AxAgTzH3TCaZHGyCMWCc0FHZIJFpOog4tLPexsrCY7Oz3R1NQr e98SP4UH8O55uMFya5lLafWNDUqpmF2Jkv3T+33QmFXN0fDKAdFTn8ocZ0Wfrw2eH9 Cy0hSS++zxNj8eVk8OHFsJzuWlpTEO0iB58eEfYeID8Yc6YWP/MfDFrPuRQhHlHJvo cM3ElXnOyX75Q== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 324C117E10FC; Tue, 23 Jun 2026 10:06:41 +0200 (CEST) Message-ID: <24670280-508d-4794-b5f4-1dda825d9289@collabora.com> Date: Tue, 23 Jun 2026 10:06:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] pinctrl: mediatek: Restore PINCTRL_MT8189 to tristate To: Justin Yeh , Sean Wang , Linus Walleij , Matthias Brugger Cc: Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260529100308.51271-1-justin.yeh@mediatek.com> <20260529100308.51271-2-justin.yeh@mediatek.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <20260529100308.51271-2-justin.yeh@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/29/26 12:02, Justin Yeh wrote: > Under the GKI + vendor_dlkm model, vendor-specific pinctrl cannot be > built into the GKI vmlinux. Upstream's recent switch of PINCTRL_MT8189 > to bool prevents building as a loadable module, which breaks DDK module > usage. Restore tristate so MT8189 pinctrl can be packaged as a kernel > module in vendor_dlkm. > > Signed-off-by: Justin Yeh The MODULE_LICENSE change shall come before this one. Besides - since there's no problem in having the pinctrl drivers as module for MT8189, I imagine that this is analogously true for all (or most of) the others. Looks like getting those to build as modules is trivial, too - so, can you at this point please do the same for all of the MediaTek pinctrl drivers that are trivial to enable as tristate? P.S.: After reordering the commits, this one is Reviewed-by: AngeloGioacchino Del Regno Thanks, Angelo > --- > drivers/pinctrl/mediatek/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig > index 4819617d9368..a75434e7e989 100644 > --- a/drivers/pinctrl/mediatek/Kconfig > +++ b/drivers/pinctrl/mediatek/Kconfig > @@ -270,7 +270,7 @@ config PINCTRL_MT8188 > map specific eint which doesn't have real gpio pin. > > config PINCTRL_MT8189 > - bool "MediaTek MT8189 pin control" > + tristate "MediaTek MT8189 pin control" > depends on OF > depends on ARM64 || COMPILE_TEST > default ARM64 && ARCH_MEDIATEK