From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838D4319601 for ; Tue, 7 Jul 2026 08:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783413139; cv=none; b=BGRAlbPfib0VmMFd5ckfVHzs3vAnBIMOk1GqAlJC5cg4EGHvv5PU2ruuk8gxRCwXSCfgKCsoWaasCzkw2aPxJURcVr/7YFGpMF3T34BheEZJOiKtRj1yidFGiistzynHOtsD6Q1Ynyj5/LZLhtjRY29xEtgUkKT5+ISbXgUcLLo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783413139; c=relaxed/simple; bh=GxJ0wg/aa764RWmNYEzMSR7JW+lkVrfxCQi2pkNhbEA=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=dNYt9CIoAfF4n0zfHsgYLcCLMwpUUD+eo7XfVS7SbOKrRpEdFO9ILFWtYi9tqHqPRGalVPNF0pxV6oRQUX0ueyzC9Q6Qo0YdSSmotIyD8ESewZiaZZnm4y5grD3JTpbyWQ9wigm0PZf5fr5Mz+yMuSh95T0TzS2+8svQdOhfjJw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dJCvceik; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CT8zzFs5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dJCvceik"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CT8zzFs5" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6678DnwO3076951 for ; Tue, 7 Jul 2026 08:32:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VouvbjaFsGUNSHVW3vymOiR/LkD//UOCZ6vwO722dTs=; b=dJCvceikkcklwupq yysajrwCw09QkMYAqfjPwPvmTjESX+6o61GsWcqW8LEwsmGVzSEjNozALmEDeKGp BgWncEG9+iT/xQ4Ye8HxJZ8kQ+kUTHQ4G0MKMahzGBIbz5Vb1J7AyOPVa1mccrVn XAJWalclwj0SDYoF8SIJVWQDF6MaEg/vUNU9hyjQ1WOvhsjtuoSpqMq9RG4/wlwD DmvjesWOgdL8Ua6sPR66vBukvcLAVSm1kWLFuPHMnj6jYnD7wMRocP81afcOF45C ysGLCYlDeHzWQclA3x0BUQEEtevCYS0PB+ydh+wqg6yQkz5E8ukchd4HJqNKAF9y /oce+g== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8vun0a73-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 08:32:17 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38112fd8b48so4541175a91.2 for ; Tue, 07 Jul 2026 01:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783413137; x=1784017937; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=VouvbjaFsGUNSHVW3vymOiR/LkD//UOCZ6vwO722dTs=; b=CT8zzFs50pY8T6OsXGwivkKpG0mwfqnYEv8Iora4fWQo2nSXi8lPpDT7rH89T5Lz+y QxRjBsn/IvNa3lSD3+Fq+IDAA0GiIjqKNqVgMbjfGdEehkB++gilp+wyi6xNGn4XRwbE L5GYSrUb9WpAbtjDxrJZFmAWOIDG/rAsWsfYAHnXBFZtK7gBQ+FVZtejRvI9Kj3p0FqR /wuS7dmDSrYlc8IePXDEyjaA24jyNA9MHvd942e00yrF5yFvWIxbqSdhbs3qqp4EcOns fo7rrOGxwPB24UGv7z2Dsp2gXzDHNZAOsJ1Kc6kOT2X1yfDUfQ9xFvMRNFX4fcAejt4q 1NLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783413137; x=1784017937; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VouvbjaFsGUNSHVW3vymOiR/LkD//UOCZ6vwO722dTs=; b=g6H5r949pLY5L0iDjZfmBm6D+NaItavz5uNGTX8TUSPAdcYYyQ2QgtdfwjSbyXFW+0 2jSHIs6IN2Rg3eCKt9R16f4UYijXsWqiyC7RUTh8V6Y87snJVAPpM3NbAbMoK1njXprz WLFawj8xkkhUX5+sofTiqjO2mNLJC3tXZsO0dfO9WsFAmQNotP8tijVwm6UgnYEEJuLx vUl+Wc9RSUaRGBi0BLK/beyu9aNW4G8AzYMG7XokM4U5uCyf66YbP46Hvm3V5+QJQqG3 v68Lue0CypF4za6Q6D/F+lzOZwie6YObo/Qrz8rHqjGELOOkVrq9cdUfDmqcj399jaM4 5ndA== X-Forwarded-Encrypted: i=1; AHgh+RprQbtA4FtaDZc9aMcfxM6C1Bu0BvgAGllqLXFCcC9jDrorXcsBS1pRz2b4/4ZlVNRN+oMeRpOOgR0whrk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3TqD4PdIUkgtKj/CYDfcHcVmDzwIhzwjVf3AfmSq08BMpGJDh uI9PX8DrZqKVe4R7Sa9Vyzr/SC+nGU9wOg1nI9uZOipq7yhuPtb4ZEWmvFmq0YYJcokozWwF1cz CoOvMq5u6qCNRZPiwxCnmtEo0gWJ7CUIh/x8nEh53rLvomHKOYtk1B1WOwN4AFHd8DOI= X-Gm-Gg: AfdE7ckzf7poXQsJEdnxBrQaCugHo0q0diMsqW4eOds/10A8YVqMR2o+9soOqaoD+N8 81w4Ck3vCugLVAWVtywYlpbZbRLum4GxXKhuMwPn9gZIycAd16o02MJcknIq/VrsSBDN0io9W7x qGmGG1gVNtUEBwLbJxfpapsEI3bmoOGANxzwibii7XK+U6SFwR2Kz+BdC6UTjamEfgjh65NeCib VCX6oSU6T2Qa1UxNCwhxDmHz5bNciE7ciOTKKmVl6bD0w3Etr6XidKLkidcheaHmmhD5k3Sjq4s SBYBT7gqkgzKUAQpuZwCGlWxsKqn4c8PUnFv6uosZCM9CtvMHeDvtJV0smpEGayZ9U/D1/ft3Q9 ODrYBE+sz56Nbu23JAfTp6qjz/gzp9s0OghnX6RxYFZH5C48M7nuElBT7zRQhF7tpJgcL4VdXWP Eruqir2Q== X-Received: by 2002:a17:90a:e704:b0:381:e73:3c2e with SMTP id 98e67ed59e1d1-38758a364e3mr4428493a91.24.1783413136952; Tue, 07 Jul 2026 01:32:16 -0700 (PDT) X-Received: by 2002:a17:90a:e704:b0:381:e73:3c2e with SMTP id 98e67ed59e1d1-38758a364e3mr4428451a91.24.1783413136394; Tue, 07 Jul 2026 01:32:16 -0700 (PDT) Received: from [10.133.33.178] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d3a65609sm683410a91.14.2026.07.07.01.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 01:32:15 -0700 (PDT) Message-ID: <2467f7a8-d7c7-41be-aae9-04a5dcadd15c@oss.qualcomm.com> Date: Tue, 7 Jul 2026 16:32:08 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9] misc: fastrpc: Allocate entire reserved memory for Audio PD in probe To: Ekansh Gupta , Srinivas Kandagatla References: <20260707061733.495-1-jianping.li@oss.qualcomm.com> <1e7d0b9f-380b-41a2-8aba-7ab25c6a8680@oss.qualcomm.com> Content-Language: en-US From: Jianping Li Cc: arnd@arndb.de, Greg KH , abelvesa@kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, stable@kernel.org In-Reply-To: <1e7d0b9f-380b-41a2-8aba-7ab25c6a8680@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDA4MSBTYWx0ZWRfX5empU1xJKfj1 NWSTh98qO6Nns/UUS+/2tVixJ0D1zjQMp4xWeiVO0Zq75aYo8lYJ3c6HTbj0PwPhJsQo2FMcwPF AS8z+aO3gjvnZEGoLbwTLPRFmb7qXqE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDA4MSBTYWx0ZWRfXxFhp88pWWK9c NuYd6u0/6mzCfiaz3Jf/OF9XrJoy3gN56nLvtFr8Gw5jJuieNFWE/vORT3/a0tBqssph5E+3p4e 6GZWq+4WyAcFLGXgoyx5qw8/zxsX8BBA1r6lKr5n+UCBqh0ozWjQsc3XW3Eyv/hs34lPwt/r75b P2fu6NY4SXKc6i7BkPmE4rlpCRbY212kcYgu8cU7oteWxcI1W7tXi5REI6s24plzzivp0/fMWBd JyECQBV5BMR3KbvPtfNizXA7q9MPszK9iioEM7HYJiohUVffAWjLrD5/oU2gR3jmsa6ne7ZqU1S 3WPQtfBm0CqEnRGqor/Sc071J9MmCKIzvyE86Wq6n7QRyA+f4eKXcWcM7I9k0j72vE7KczfV6mE nc3C8AslwNuA6cfn03KyXzDHuRN/LxkyWtcqLdwNTFjNSO5guF9dstMHYBtBsn+F5ILqSpmhs37 b+fLJVhSx+knaXzfXkA== X-Proofpoint-GUID: 2H9-7sLvzpc6iqiMP8rWD_SK206wRw7h X-Authority-Analysis: v=2.4 cv=N+IZ0W9B c=1 sm=1 tr=0 ts=6a4cb991 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=Yk0qE0SaCswAtkPT5K8A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: 2H9-7sLvzpc6iqiMP8rWD_SK206wRw7h X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_02,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 priorityscore=1501 clxscore=1015 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070081 On 7/7/2026 3:01 PM, Ekansh Gupta wrote: > On 07-07-2026 11:47, Jianping Li wrote: >> Allocating and freeing Audio PD memory from userspace is unsafe because >> the kernel cannot reliably determine when the DSP has finished using the >> memory. Userspace may free buffers while they are still in use by the DSP, >> and remote free requests cannot be safely trusted. >> >> Additionally, the current implementation allows userspace to repeatedly >> grow the Audio PD heap, but does not support shrinking it. This can lead >> to unbounded memory usage over time, effectively causing a memory leak. >> >> Fix this by allocating the entire Audio PD reserved-memory region during >> rpmsg probe and tying its lifetime to the rpmsg channel. This removes >> userspace-controlled alloc/free and ensures that memory is reclaimed only >> when the DSP process is torn down. >> >> Add explicit validation for remote_heap presence and size before sending >> the memory to DSP, and fail early if the reserved-memory region is >> missing or incomplete. >> >> Fixes: 0871561055e66 ("misc: fastrpc: Add support for audiopd") >> Cc: stable@kernel.org >> Signed-off-by: Jianping Li >> --- > Changes in vN and lore link to v(N-1) series would help here.> > drivers/misc/fastrpc.c | 119 +++++++++++++++++++++++------------------ Will add changelog and lore link in next version. >> 1 file changed, 66 insertions(+), 53 deletions(-) >> >> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c >> index d86e79134c68..1ec37e6c68a2 100644 >> --- a/drivers/misc/fastrpc.c >> +++ b/drivers/misc/fastrpc.c >> @@ -276,6 +276,8 @@ struct fastrpc_channel_ctx { >> struct kref refcount; >> /* Flag if dsp attributes are cached */ >> bool valid_attributes; >> + /* Flag if audio PD init mem was allocated */ >> + bool audio_init_mem; >> u32 dsp_attributes[FASTRPC_MAX_DSP_ATTRIBUTES]; >> struct fastrpc_device *secure_fdevice; >> struct fastrpc_device *fdevice; >> @@ -1344,15 +1346,24 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, >> struct fastrpc_init_create_static init; >> struct fastrpc_invoke_args *args; >> struct fastrpc_phy_page pages[1]; >> + struct fastrpc_channel_ctx *cctx = fl->cctx; >> char *name; >> int err; >> - bool scm_done = false; >> struct { >> int client_id; >> u32 namelen; >> u32 pageslen; >> } inbuf; >> u32 sc; >> + unsigned long flags; >> + >> + if (!cctx->remote_heap || !cctx->remote_heap->dma_addr || >> + !cctx->remote_heap->size) { >> + err = -ENOMEM; >> + dev_err(fl->sctx->dev, >> + "remote heap memory region is not added\n"); >> + return err; >> + } >> >> args = kzalloc_objs(*args, FASTRPC_CREATE_STATIC_PROCESS_NARGS); >> if (!args) >> @@ -1376,31 +1387,6 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, >> inbuf.client_id = fl->client_id; >> inbuf.namelen = init.namelen; >> inbuf.pageslen = 0; >> - if (!fl->cctx->remote_heap) { >> - err = fastrpc_remote_heap_alloc(fl, fl->sctx->dev, init.memlen, >> - &fl->cctx->remote_heap); >> - if (err) >> - goto err_name; >> - >> - /* Map if we have any heap VMIDs associated with this ADSP Static Process. */ >> - if (fl->cctx->vmcount) { >> - u64 src_perms = BIT(QCOM_SCM_VMID_HLOS); >> - >> - err = qcom_scm_assign_mem(fl->cctx->remote_heap->dma_addr, >> - (u64)fl->cctx->remote_heap->size, >> - &src_perms, >> - fl->cctx->vmperms, fl->cctx->vmcount); >> - if (err) { >> - dev_err(fl->sctx->dev, >> - "Failed to assign memory with dma_addr %pad size 0x%llx err %d\n", >> - &fl->cctx->remote_heap->dma_addr, >> - fl->cctx->remote_heap->size, err); >> - goto err_map; >> - } >> - scm_done = true; >> - inbuf.pageslen = 1; >> - } >> - } >> >> fl->pd = USER_PD; >> >> @@ -1412,8 +1398,24 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, >> args[1].length = inbuf.namelen; >> args[1].fd = -1; >> >> - pages[0].addr = fl->cctx->remote_heap->dma_addr; >> - pages[0].size = fl->cctx->remote_heap->size; >> + /* >> + * Audio PD is a static PD and retains the remote heap >> + * information across daemon restarts. Therefore only >> + * the first attach should provide heap information to >> + * DSP. Subsequent attaches reuse the previously >> + * initialized memory pool. >> + */ >> + spin_lock_irqsave(&cctx->lock, flags); >> + if (!cctx->audio_init_mem) { >> + pages[0].addr = cctx->remote_heap->dma_addr; >> + pages[0].size = cctx->remote_heap->size; >> + cctx->audio_init_mem = true; >> + inbuf.pageslen = 1; >> + } else { >> + pages[0].addr = 0; >> + pages[0].size = 0; >> + } >> + spin_unlock_irqrestore(&cctx->lock, flags); >> >> args[2].ptr = (u64)(uintptr_t) pages; >> args[2].length = sizeof(*pages); >> @@ -1431,27 +1433,7 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl, >> >> return 0; >> err_invoke: >> - if (fl->cctx->vmcount && scm_done) { >> - u64 src_perms = 0; >> - struct qcom_scm_vmperm dst_perms; >> - u32 i; >> - >> - for (i = 0; i < fl->cctx->vmcount; i++) >> - src_perms |= BIT(fl->cctx->vmperms[i].vmid); >> - >> - dst_perms.vmid = QCOM_SCM_VMID_HLOS; >> - dst_perms.perm = QCOM_SCM_PERM_RWX; >> - err = qcom_scm_assign_mem(fl->cctx->remote_heap->dma_addr, >> - (u64)fl->cctx->remote_heap->size, >> - &src_perms, &dst_perms, 1); >> - if (err) >> - dev_err(fl->sctx->dev, "Failed to assign memory dma_addr %pad size 0x%llx err %d\n", >> - &fl->cctx->remote_heap->dma_addr, fl->cctx->remote_heap->size, err); >> - } >> -err_map: >> - fastrpc_buf_free(fl->cctx->remote_heap); >> - fl->cctx->remote_heap = NULL; >> -err_name: >> + cctx->audio_init_mem = false; >> kfree(name); >> err: >> kfree(args); >> @@ -2418,12 +2400,23 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) >> } >> } >> >> - if (domain_id == SDSP_DOMAIN_ID) { >> + if (domain_id == SDSP_DOMAIN_ID || domain_id == ADSP_DOMAIN_ID) { >> struct resource res; >> u64 src_perms; >> >> err = of_reserved_mem_region_to_resource(rdev->of_node, 0, &res); >> if (!err) { >> + if (domain_id == ADSP_DOMAIN_ID) { >> + data->remote_heap = >> + kzalloc_obj(*data->remote_heap, GFP_KERNEL); > drop GFP_KERNEL from kzalloc_obj()> + if (!data->remote_heap) { ACK,I'll drop GFP_KERNEL. >> + err = -ENOMEM; >> + goto err_free_data; >> + } >> + >> + data->remote_heap->dma_addr = res.start; >> + data->remote_heap->size = resource_size(&res); >> + } >> src_perms = BIT(QCOM_SCM_VMID_HLOS); >> >> err = qcom_scm_assign_mem(res.start, resource_size(&res), &src_perms, >> @@ -2431,7 +2424,6 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) >> if (err) >> goto err_free_data; >> } >> - >> } >> >> secure_dsp = !(of_property_read_bool(rdev->of_node, "qcom,non-secure-domain")); >> @@ -2490,6 +2482,7 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) >> misc_deregister(&data->secure_fdevice->miscdev); >> >> err_free_data: >> + kfree(data->remote_heap); >> kfree(data); >> return err; >> } >> @@ -2512,6 +2505,7 @@ static void fastrpc_rpmsg_remove(struct rpmsg_device *rpdev) >> struct fastrpc_buf *buf, *b; >> struct fastrpc_user *user; >> unsigned long flags; >> + int err; >> >> /* No invocations past this point */ >> spin_lock_irqsave(&cctx->lock, flags); >> @@ -2529,8 +2523,27 @@ static void fastrpc_rpmsg_remove(struct rpmsg_device *rpdev) >> list_for_each_entry_safe(buf, b, &cctx->invoke_interrupted_mmaps, node) >> list_del(&buf->node); >> >> - if (cctx->remote_heap) >> - fastrpc_buf_free(cctx->remote_heap); >> + if (cctx->remote_heap && cctx->vmcount) { >> + u64 src_perms = 0; >> + struct qcom_scm_vmperm dst_perms; >> + >> + for (u32 i = 0; i < cctx->vmcount; i++) > for the iterator use top-of-block declaration style for consistency> + > src_perms |= BIT(cctx->vmperms[i].vmid); Will fix. >> + >> + dst_perms.vmid = QCOM_SCM_VMID_HLOS; >> + dst_perms.perm = QCOM_SCM_PERM_RWX; >> + >> + err = qcom_scm_assign_mem(cctx->remote_heap->dma_addr, >> + cctx->remote_heap->size, &src_perms, >> + &dst_perms, 1); >> + if (err) >> + dev_err(&rpdev->dev, >> + "Failed to assign memory back to HLOS: dma_addr %pad size %#llx err %d\n", >> + &cctx->remote_heap->dma_addr, cctx->remote_heap->size, err); >> + } >> + >> + kfree(cctx->remote_heap); >> + cctx->remote_heap = NULL; >> >> of_platform_depopulate(&rpdev->dev); >>