From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757196AbcJ3Rny (ORCPT ); Sun, 30 Oct 2016 13:43:54 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:43281 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754259AbcJ3Rnx (ORCPT ); Sun, 30 Oct 2016 13:43:53 -0400 Subject: Re: [PATCH 01/10] staging: iio: tsl2583: add of_match table for device tree support To: Brian Masney , linux-iio@vger.kernel.org References: <1477648821-3786-1-git-send-email-masneyb@onstation.org> <1477648821-3786-2-git-send-email-masneyb@onstation.org> Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, lars@metafoo.de, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, Mark.Rutland@arm.com From: Jonathan Cameron Message-ID: <246d8513-3505-31cd-4cfa-4f2c2e9266d8@kernel.org> Date: Sun, 30 Oct 2016 17:43:51 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477648821-3786-2-git-send-email-masneyb@onstation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/10/16 11:00, Brian Masney wrote: > Add device tree support for the tsl2583 IIO driver with no custom > properties. > > Signed-off-by: Brian Masney Trivial enough that I feel I can take this without an explicit devicetree ack. Of course one is always welcome if anyone gets a chance to look at it. I won't have it exposed in a non rebasing tree until perhaps the second half of the week. > --- > .../devicetree/bindings/iio/light/tsl2583.txt | 26 ++++++++++++++++++++++ > drivers/staging/iio/light/tsl2583.c | 13 +++++++++++ > 2 files changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2583.txt > > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2583.txt b/Documentation/devicetree/bindings/iio/light/tsl2583.txt > new file mode 100644 > index 0000000..8e2066c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/tsl2583.txt > @@ -0,0 +1,26 @@ > +* TAOS TSL 2580/2581/2583 ALS sensor > + > +Required properties: > + > + - compatible: Should be one of > + "amstaos,tsl2580" > + "amstaos,tsl2581" > + "amstaos,tsl2583" > + - reg: the I2C address of the device > + > +Optional properties: > + > + - interrupt-parent: should be the phandle for the interrupt controller > + - interrupts: the sole interrupt generated by the device > + > + Refer to interrupt-controller/interrupts.txt for generic interrupt client > + node bindings. > + > + - vcc-supply: phandle to the regulator that provides power to the sensor. > + > +Example: > + > +tsl2581@29 { > + compatible = "amstaos,tsl2581"; > + reg = <0x29>; > +}; > diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c > index 08f1583..fd4b6ef 100644 > --- a/drivers/staging/iio/light/tsl2583.c > +++ b/drivers/staging/iio/light/tsl2583.c > @@ -947,11 +947,24 @@ static struct i2c_device_id taos_idtable[] = { > }; > MODULE_DEVICE_TABLE(i2c, taos_idtable); > > +#ifdef CONFIG_OF > +static const struct of_device_id taos2583_of_match[] = { > + { .compatible = "amstaos,tsl2580", }, > + { .compatible = "amstaos,tsl2581", }, > + { .compatible = "amstaos,tsl2583", }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, taos2583_of_match); > +#else > +#define taos2583_of_match NULL > +#endif > + > /* Driver definition */ > static struct i2c_driver taos_driver = { > .driver = { > .name = "tsl2583", > .pm = TAOS_PM_OPS, > + .of_match_table = taos2583_of_match, > }, > .id_table = taos_idtable, > .probe = taos_probe, >