From: Shuah Khan <skhan@linuxfoundation.org>
To: Aleksandr Nogikh <nogikh@google.com>
Cc: syzbot <syzbot@kernel.org>,
syzkaller-bugs@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Valentina Manea <valentina.manea.m@gmail.com>,
Nobuo Iwata <nobuo.iwata@fujixerox.co.jp>,
i@zenithal.me, linux-kernel@vger.kernel.org,
syzbot@lists.linux.dev, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] usbip: fix use-after-free in event_handler()
Date: Tue, 11 Aug 2026 16:39:08 -0600 [thread overview]
Message-ID: <246f34a4-e564-4f0a-911c-1f9f0b4ae1e9@linuxfoundation.org> (raw)
In-Reply-To: <CANp29Y4NLVebq6L7STgcFJYSJo81ZpO4hNvaJQT14OGDZqwzxQ@mail.gmail.com>
On 8/11/26 07:07, Aleksandr Nogikh wrote:
> On Mon, Aug 10, 2026 at 9:33 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
> < ... >
>>>
>>> During unbinding, we must wait for the scheduled removal event to
>>> finish before we can safely free the device structures. From what I
>>> see in the code, once we have reached wait_event_interruptible(),
>>> there's no way to abort the process or somehow gracefully handle the
>>> error.
>>>
>>
>> Yes I agree with you on rewinding being hard.
>>
>> Care to explain the scope of this assist?
>>
>> Assisted-by: Gemini:gemini-3.5-flash Gemini:gemini-3.1-pro-preview syzbot
>
> It was generated by the syzbot's AI patch generation agent:
> https://github.com/google/syzkaller/blob/master/docs/syzbot_ai_patches.md
>
> We manually review the patches it suggests and upstream those we
> believe are fully correct.
>
As you are reviewing this generated code, did you look into scenarios
where the driver to hang in wait_event()?
thanks,
-- Shuah
prev parent reply other threads:[~2026-08-11 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 15:05 syzbot
2026-08-04 17:31 ` Shuah Khan
2026-08-07 14:18 ` Aleksandr Nogikh
2026-08-10 19:33 ` Shuah Khan
2026-08-11 13:07 ` Aleksandr Nogikh
2026-08-11 22:39 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=246f34a4-e564-4f0a-911c-1f9f0b4ae1e9@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nobuo.iwata@fujixerox.co.jp \
--cc=nogikh@google.com \
--cc=shuah@kernel.org \
--cc=syzbot@kernel.org \
--cc=syzbot@lists.linux.dev \
--cc=syzkaller-bugs@googlegroups.com \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®