From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7C6FC433DB for ; Mon, 8 Feb 2021 21:03:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B00EE64E45 for ; Mon, 8 Feb 2021 21:03:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235478AbhBHVDK (ORCPT ); Mon, 8 Feb 2021 16:03:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33149 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236490AbhBHTvY (ORCPT ); Mon, 8 Feb 2021 14:51:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612813797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fbn7GdaBKVLKbPiuQemPacIJV9xqx2rXfL8BnWQu1BA=; b=QXh6kN8fIX1TRM/eIdd61Mk3sgVrrl47alh0UyBfnIcwl3uXFSb1cw3PD/ytRhjFZBiYWr SOLXPixs4m4r05MSfjXPEpBDHNwR3qvNEJojwacrLPnoCfqVPEkAsgZIXPHnkffsh4MmkS Ke4wiPHEcMhI8FriNPPzU5TdPuhAsl8= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-_DEBITShN-yRR0z9iiMCZw-1; Mon, 08 Feb 2021 14:49:54 -0500 X-MC-Unique: _DEBITShN-yRR0z9iiMCZw-1 Received: by mail-ej1-f69.google.com with SMTP id k3so13418803ejr.16 for ; Mon, 08 Feb 2021 11:49:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Fbn7GdaBKVLKbPiuQemPacIJV9xqx2rXfL8BnWQu1BA=; b=rSUcHZZREgOwxQe2HiNLJFNNwtPBMMhtHEyMwNMppfm58syrLV6Oz7VBi1BI2wSsQ5 O44hR4kKR46KGLNPSZ1za9VmNufFd/Zs+QPunSKEFVhCKd05KyJubdgrGPO+WUb/S/X/ a9FRAsd8UXcCT3dRRCPH02C9POBbgwnMpZzZzHD+oh/1TIGlH7Y4X3Z27GE6DFytzVAg R7mhR95eD+B1wOsN6qSKIBDpCkySkDk+85gAX0lzRwEXvrKJi8lIobGuf8EA5BVfJ037 LRkQ3+CWYQeA4F7d2HKbF2OkVn4NMQgWn5HopktnDqQ7EMD0XIXAzQVaeUTvQ7GiyqS6 HwnQ== X-Gm-Message-State: AOAM533z6SV55Iceo4h1Kyq3v+POZlHX12PbdFsliN1MtjBfZWbV4Jmp n86+eEbnODMlP2fZ1po/YTYMLPwD5UtletTwSNoRoXiWdmE5Swk1qciOwWp/qDhlXg3FSFZHkxR Q9Vl7792J/XFMAPkBM3MgfoWv X-Received: by 2002:a05:6402:1398:: with SMTP id b24mr18085554edv.108.1612813793315; Mon, 08 Feb 2021 11:49:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwARQ4C58IlhAqgbkOSrum8emzTUjTpBZYrfMp7Hx+e0BH4Olv/xtake/poBSSiELcuHYuUmg== X-Received: by 2002:a5d:4a09:: with SMTP id m9mr21584778wrq.122.1612813299508; Mon, 08 Feb 2021 11:41:39 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id d23sm423802wmd.11.2021.02.08.11.41.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 11:41:36 -0800 (PST) Subject: Re: [PATCH] KVM: x86: compile out TDP MMU on 32-bit systems To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <20210206145333.47314-1-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: <24735404-2cde-42a6-14c4-f734da5d5493@redhat.com> Date: Mon, 8 Feb 2021 20:41:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/02/21 20:26, Sean Christopherson wrote: > This can/should also expand the #ifdef to the TDP-only fields in > kvm_mmu_page. I also vote to #ifdef out all of tdp_iter.h, and probably > the TDP-only fields in struct kvm_arch. Agreed except for tdp_iter.h, I don't see the point since it is not used outside tdp_iter.c and tdp_mmu.c. Paolo