From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753681AbbGAXGD (ORCPT ); Wed, 1 Jul 2015 19:06:03 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:46494 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752030AbbGAXF5 (ORCPT ); Wed, 1 Jul 2015 19:05:57 -0400 From: "Rafael J. Wysocki" To: Tomeu Vizoso Cc: linux-kernel@vger.kernel.org, Mark Brown , devicetree@vger.kernel.org, Rob Herring , Grant Likely Subject: Re: [PATCH v1 01/10] of/platform: Set fwnode field for new devices Date: Thu, 02 Jul 2015 01:32:17 +0200 Message-ID: <2474190.tMuKjeazpI@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1435676108-20590-2-git-send-email-tomeu.vizoso@collabora.com> References: <1435676108-20590-1-git-send-email-tomeu.vizoso@collabora.com> <1435676108-20590-2-git-send-email-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 30, 2015 04:54:59 PM Tomeu Vizoso wrote: > When allocating a new platform device, set the fwnode field in the > struct device to point to the device_node. > > Signed-off-by: Tomeu Vizoso > --- > > drivers/of/platform.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index ddf8e42..e880f55 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -139,6 +139,7 @@ struct platform_device *of_device_alloc(struct device_node *np, > } > > dev->dev.of_node = of_node_get(np); > + dev->dev.fwnode = &dev->dev.of_node->fwnode; What about using set_primary_fwnode() instead of the direct assignment? Or even having a macro analogous to ACPI_COMPANION_SET() for this purpose? > dev->dev.parent = parent ? : &platform_bus; > > if (bus_id) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.