From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13540C433FE for ; Tue, 11 Jan 2022 16:29:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349997AbiAKQ3E (ORCPT ); Tue, 11 Jan 2022 11:29:04 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:57596 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349983AbiAKQ3D (ORCPT ); Tue, 11 Jan 2022 11:29:03 -0500 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 2302E4001E for ; Tue, 11 Jan 2022 16:29:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1641918541; bh=/UWC8fh48tJ/0lJUYbP565Qiaw0ihLI819cwhhrknrE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BCVqdTBTvp60MhoLET/+XCpUHF5xaE7pwDE/k2sUBfUgas4nIvNTDT4u2y+aMAJ8v V4nxADhVMr3cwX/E3+2lZU/O1DxnWSkdRgsr3MeqM/w7RpVy/NNwLPMsYoLihRMUBM ZaXPfUJhQlAMW1OlS4k1fglPW/iko2NlEYpl59TkNX1JfBEzaFi5vok8d3V7H3y6gQ 5J2EbB/MEdzvk3VMw2DiUv6jJQVUC4M2Tg/RvOKffUfr/VdNPNUbKy0j4kwFJ0J+LD mkwdbNUK13+xEz6jifPs0tzjYctXqCDmfgTN+DhTDHIm7awdbYFCY0eRrnYix6Qn7a cWX57CVOaFitQ== Received: by mail-ed1-f72.google.com with SMTP id l14-20020aa7cace000000b003f7f8e1cbbdso13755524edt.20 for ; Tue, 11 Jan 2022 08:29:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/UWC8fh48tJ/0lJUYbP565Qiaw0ihLI819cwhhrknrE=; b=BJViU2qRn0PW9AqKaEBpI4qAtTkw/pNVMo3qjCbluq5GTGJBaa/ZCsHJg4t6cV+SmZ s/vsD1runhcWmuSGP3Itd8GPsR9CpQXuuDtClpSJF0z+Kaq4efKvh+Nvk1zXURagCGvA ZsQ9JL0uQ268G4AH5ZbkM+Z5u5gPiuE9oigmF04LoQR5VkO98AuqayJNLidB9rnWliJd xwscVLOLdP+Mf08zWtiSJofpib0w+9Txh+wsl5X+K8KZHk3zBs2FdxwIfdtCgfugy992 N92qeFl5ZDFHibBnH9AKIHPcBfTGyEXeAdRczmIYV7ut5FUkKM2mMKfSQYJinvR8gv8v boJQ== X-Gm-Message-State: AOAM530gZXF1AFH2nC+NC/VfudU+Ytgdrfkw2BlPeFe5203O9sqoNHls t/c59O0X89vf+phlHtOsFLxYws+2SUd+fJHxN03eB3KH5qqR3k0Ui0ITXt11MSwoP5di5VP0ORI cLgN6jqYRkk5ox8gCVezr+CIjRZE0cjMd+gzURB4YUA== X-Received: by 2002:a17:906:6a0d:: with SMTP id qw13mr4613417ejc.490.1641918539189; Tue, 11 Jan 2022 08:28:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2Ci90Bb2YR66uedUPza99URW+gs5GRrvVHEekvDgn/Gx/4hsqwrQCSqhIZaBM5/tI5JUk7Q== X-Received: by 2002:a17:906:6a0d:: with SMTP id qw13mr4613391ejc.490.1641918538955; Tue, 11 Jan 2022 08:28:58 -0800 (PST) Received: from [192.168.0.25] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id hs32sm3465636ejc.180.2022.01.11.08.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jan 2022 08:28:58 -0800 (PST) Message-ID: <24759eaf-ede6-32e4-a673-cba3659d4ad3@canonical.com> Date: Tue, 11 Jan 2022 17:28:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 4/4] dt-bindings: mfd: maxim,max77693: convert to dtschema Content-Language: en-US To: Rob Herring Cc: Chanwoo Choi , Bartlomiej Zolnierkiewicz , Pavel Machek , Lee Jones , Sebastian Reichel , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <20211228163930.35524-1-krzysztof.kozlowski@canonical.com> <20211228163930.35524-5-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/01/2022 20:10, Rob Herring wrote: > On Tue, Dec 28, 2021 at 05:39:30PM +0100, Krzysztof Kozlowski wrote: >> Convert the MFD part of Maxim MAX77693 MUIC to DT schema format. The >> example DTS was copied from existing DTS (exynos4412-midas.dtsi), so >> keep the license as GPL-2.0-only. >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> .../devicetree/bindings/mfd/max77693.txt | 194 ------------------ >> .../bindings/mfd/maxim,max77693.yaml | 139 +++++++++++++ >> MAINTAINERS | 2 +- >> 3 files changed, 140 insertions(+), 195 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/mfd/max77693.txt >> create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max77693.yaml >> >> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt >> deleted file mode 100644 >> index 1032df14498b..000000000000 >> --- a/Documentation/devicetree/bindings/mfd/max77693.txt >> +++ /dev/null >> @@ -1,194 +0,0 @@ >> -Maxim MAX77693 multi-function device >> - >> -MAX77693 is a Multifunction device with the following submodules: >> -- PMIC, >> -- CHARGER, >> -- LED, >> -- MUIC, >> -- HAPTIC >> - >> -It is interfaced to host controller using i2c. >> -This document describes the bindings for the mfd device. >> - >> -Required properties: >> -- compatible : Must be "maxim,max77693". >> -- reg : Specifies the i2c slave address of PMIC block. >> -- interrupts : This i2c device has an IRQ line connected to the main SoC. >> - >> -Optional properties: >> -- regulators : The regulators of max77693 have to be instantiated under subnode >> - named "regulators" using the following format. >> - >> - regulators { >> - regulator-compatible = ESAFEOUT1/ESAFEOUT2/CHARGER >> - standard regulator constraints[*]. >> - }; >> - >> - [*] refer Documentation/devicetree/bindings/regulator/regulator.txt >> - >> -- haptic : The MAX77693 haptic device utilises a PWM controlled motor to provide >> - users with tactile feedback. PWM period and duty-cycle are varied in >> - order to provide the appropriate level of feedback. >> - >> - Required properties: >> - - compatible : Must be "maxim,max77693-haptic" >> - - haptic-supply : power supply for the haptic motor >> - [*] refer Documentation/devicetree/bindings/regulator/regulator.txt >> - - pwms : phandle to the physical PWM(Pulse Width Modulation) device. >> - PWM properties should be named "pwms". And number of cell is different >> - for each pwm device. >> - To get more information, please refer to documentation. >> - [*] refer Documentation/devicetree/bindings/pwm/pwm.txt >> - >> -- charger : Node configuring the charger driver. >> - If present, required properties: >> - - compatible : Must be "maxim,max77693-charger". >> - >> - Optional properties (if not set, defaults will be used): >> - - maxim,constant-microvolt : Battery constant voltage in uV. The charger >> - will operate in fast charge constant current mode till battery voltage >> - reaches this level. Then the charger will switch to fast charge constant >> - voltage mode. Also vsys (system voltage) will be set to this value when >> - DC power is supplied but charger is not enabled. >> - Valid values: 3650000 - 4400000, step by 25000 (rounded down) >> - Default: 4200000 >> - >> - - maxim,min-system-microvolt : Minimal system voltage in uV. >> - Valid values: 3000000 - 3700000, step by 100000 (rounded down) >> - Default: 3600000 >> - >> - - maxim,thermal-regulation-celsius : Temperature in Celsius for entering >> - high temperature charging mode. If die temperature exceeds this value >> - the charging current will be reduced by 105 mA/Celsius. >> - Valid values: 70, 85, 100, 115 >> - Default: 100 >> - >> - - maxim,battery-overcurrent-microamp : Overcurrent protection threshold >> - in uA (current from battery to system). >> - Valid values: 2000000 - 3500000, step by 250000 (rounded down) >> - Default: 3500000 >> - >> - - maxim,charge-input-threshold-microvolt : Threshold voltage in uV for >> - triggering input voltage regulation loop. If input voltage decreases >> - below this value, the input current will be reduced to reach the >> - threshold voltage. >> - Valid values: 4300000, 4700000, 4800000, 4900000 >> - Default: 4300000 >> - >> -- led : the LED submodule device node >> - >> -There are two LED outputs available - FLED1 and FLED2. Each of them can >> -control a separate LED or they can be connected together to double >> -the maximum current for a single connected LED. One LED is represented >> -by one child node. >> - >> -Required properties: >> -- compatible : Must be "maxim,max77693-led". >> - >> -Optional properties: >> -- maxim,boost-mode : >> - In boost mode the device can produce up to 1.2A of total current >> - on both outputs. The maximum current on each output is reduced >> - to 625mA then. If not enabled explicitly, boost setting defaults to >> - LEDS_BOOST_FIXED in case both current sources are used. >> - Possible values: >> - LEDS_BOOST_OFF (0) - no boost, >> - LEDS_BOOST_ADAPTIVE (1) - adaptive mode, >> - LEDS_BOOST_FIXED (2) - fixed mode. >> -- maxim,boost-mvout : Output voltage of the boost module in millivolts. >> - Valid values: 3300 - 5500, step by 25 (rounded down) >> - Default: 3300 >> -- maxim,mvsys-min : Low input voltage level in millivolts. Flash is not fired >> - if chip estimates that system voltage could drop below this level due >> - to flash power consumption. >> - Valid values: 2400 - 3400, step by 33 (rounded down) >> - Default: 2400 >> - >> -Required properties for the LED child node: >> -- led-sources : see Documentation/devicetree/bindings/leds/common.txt; >> - device current output identifiers: 0 - FLED1, 1 - FLED2 >> -- led-max-microamp : see Documentation/devicetree/bindings/leds/common.txt >> - Valid values for a LED connected to one FLED output: >> - 15625 - 250000, step by 15625 (rounded down) >> - Valid values for a LED connected to both FLED outputs: >> - 15625 - 500000, step by 15625 (rounded down) >> -- flash-max-microamp : see Documentation/devicetree/bindings/leds/common.txt >> - Valid values for a single LED connected to one FLED output >> - (boost mode must be turned off): >> - 15625 - 1000000, step by 15625 (rounded down) >> - Valid values for a single LED connected to both FLED outputs: >> - 15625 - 1250000, step by 15625 (rounded down) >> - Valid values for two LEDs case: >> - 15625 - 625000, step by 15625 (rounded down) >> -- flash-max-timeout-us : see Documentation/devicetree/bindings/leds/common.txt >> - Valid values: 62500 - 1000000, step by 62500 (rounded down) >> - >> -Optional properties for the LED child node: >> -- label : see Documentation/devicetree/bindings/leds/common.txt >> - >> -Optional nodes: >> -- max77693-muic : >> - Node used only by extcon consumers. >> - Required properties: >> - - compatible : "maxim,max77693-muic" >> - >> -Example: >> -#include >> - >> - max77693@66 { >> - compatible = "maxim,max77693"; >> - reg = <0x66>; >> - interrupt-parent = <&gpx1>; >> - interrupts = <5 IRQ_TYPE_LEVEL_LOW>; >> - >> - regulators { >> - esafeout@1 { >> - regulator-compatible = "ESAFEOUT1"; >> - regulator-name = "ESAFEOUT1"; >> - regulator-boot-on; >> - }; >> - esafeout@2 { >> - regulator-compatible = "ESAFEOUT2"; >> - regulator-name = "ESAFEOUT2"; >> - }; >> - charger@0 { >> - regulator-compatible = "CHARGER"; >> - regulator-name = "CHARGER"; >> - regulator-min-microamp = <60000>; >> - regulator-max-microamp = <2580000>; >> - regulator-boot-on; >> - }; >> - }; >> - >> - haptic { >> - compatible = "maxim,max77693-haptic"; >> - haptic-supply = <&haptic_supply>; >> - pwms = <&pwm 0 40000 0>; >> - pwm-names = "haptic"; >> - }; >> - >> - charger { >> - compatible = "maxim,max77693-charger"; >> - >> - maxim,constant-microvolt = <4200000>; >> - maxim,min-system-microvolt = <3600000>; >> - maxim,thermal-regulation-celsius = <75>; >> - maxim,battery-overcurrent-microamp = <3000000>; >> - maxim,charge-input-threshold-microvolt = <4300000>; >> - }; >> - >> - led { >> - compatible = "maxim,max77693-led"; >> - maxim,boost-mode = ; >> - maxim,boost-mvout = <5000>; >> - maxim,mvsys-min = <2400>; >> - >> - camera_flash: flash-led { >> - label = "max77693-flash"; >> - led-sources = <0>, <1>; >> - led-max-microamp = <500000>; >> - flash-max-microamp = <1250000>; >> - flash-max-timeout-us = <1000000>; >> - }; >> - }; >> - }; >> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77693.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77693.yaml >> new file mode 100644 >> index 000000000000..bc9c90bd4ff9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77693.yaml >> @@ -0,0 +1,139 @@ >> +# SPDX-License-Identifier: GPL-2.0-only >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mfd/maxim,max77693.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Maxim MAX77693 MicroUSB and Companion Power Management IC >> + >> +maintainers: >> + - Chanwoo Choi >> + - Krzysztof Kozlowski >> + >> +description: | >> + This is a part of device tree bindings for Maxim MAX77693 MicroUSB >> + Integrated Circuit (MUIC). >> + >> + The Maxim MAX77693 is a MicroUSB and Companion Power Management IC which >> + includes voltage current regulators, charger, LED/flash, haptic motor driver >> + and MicroUSB management IC. >> + >> +properties: >> + compatible: >> + const: maxim,max77693 >> + >> + interrupts: >> + maxItems: 1 >> + >> + reg: >> + maxItems: 1 >> + >> + charger: >> + $ref: ../power/supply/maxim,max77693.yaml > > /schemas/power/supply/... > >> + >> + led: >> + $ref: ../leds/maxim,max77693.yaml > > ditto > >> + >> + max77693-muic: >> + type: object > > additionalProperties: false > >> + properties: >> + compatible: >> + const: maxim,max77693-muic >> + >> + required: >> + - compatible >> + >> + motor-driver: >> + type: object > > additionalProperties: false > Thanks, fixed all issues. Best regards, Krzysztof