From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2E3C6FD1C for ; Wed, 22 Mar 2023 21:42:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbjCVVmp (ORCPT ); Wed, 22 Mar 2023 17:42:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbjCVVmm (ORCPT ); Wed, 22 Mar 2023 17:42:42 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A192B2FCDA for ; Wed, 22 Mar 2023 14:42:41 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id ek18so78732502edb.6 for ; Wed, 22 Mar 2023 14:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679521360; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jg9tSWAP2QBlPFC6Uk7vBpvg/zpu+PHPpGRA2+gIPBw=; b=Bvjsp4F4PvN/4IbBDsDWgF6UZuOr0HIkdC4x31cck7sPEOcrtmoF41x/Vyew2LvjFR wAJ5z5/DijkP1s2QD88CElYS2CkDSWQ2UD1xXNQ9ZuUi0xlw2b14eN/FmQksw2szbQ6j EK3zuG54zn+B0ajBvfkmCOAxs6C3kMtgt/dPGGmQVxn/bjB/L4ir/KlTPBl2Ds0tb21Z 8SsqzaInIv5v34pj8zNOBu35SrCNTsLx75w/h465+OX2RUw730ExiuHaNac/DZaXWpAX WiHuLUiucTyCQwLYovkgGVBliwMxv2vROBuWJOZqveqDYWBzR3mPXGiFwMnwa6GulcCA DXEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679521360; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jg9tSWAP2QBlPFC6Uk7vBpvg/zpu+PHPpGRA2+gIPBw=; b=Z9+cK603yPC+l0w9/frebuLx8uB7Eput4W8hW5ccBpVre/oF3jDT5IJyZAffZ9u1lk 9fVLnxMIDhpYR2AyP0xsHsEqzUbWwPSJeRBgxEEIj8CkBVoqaiywK1D1iHXUVxC9dPoZ vKOL9L5RwLumJi5/A/BFlKovh2wkm7Zn3cYBaBbSF7scKEsufEROElgVHIp+1ORT4IwT z23nd4J8P+5FDaccslrEkoeor196GF4ZxllcTYbCFeqVJ49OsOxX1jljN5m/uE7dPtRF Vp5LmgU5N0cMYcb8e/EGavciuDCfvDYDpaJ7xnWlRUVRxgcFQs8O/kYV6ZCoQdEp5bZw dmdQ== X-Gm-Message-State: AO0yUKW6IJ/3vel359U2svj0VfR6VqiIq2Ixn1nW8IamOB8+CHB28qsr JYjvxvqjXHG7XpaUqvi34wrZdg== X-Google-Smtp-Source: AK7set9S7vlHaPQk+/iOpvQzXSlZJcMwxUj0BsgSMuA85DY34E9csw8r5UTjJPWpti7s4VnZutaMQQ== X-Received: by 2002:a17:906:7102:b0:8b1:806b:7dbb with SMTP id x2-20020a170906710200b008b1806b7dbbmr8817603ejj.51.1679521360161; Wed, 22 Mar 2023 14:42:40 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:626d:5729:6e71:4c22? ([2a02:810d:15c0:828:626d:5729:6e71:4c22]) by smtp.gmail.com with ESMTPSA id ja21-20020a170907989500b0093338259b2bsm6211230ejc.207.2023.03.22.14.42.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 14:42:39 -0700 (PDT) Message-ID: <24767874-0b26-78c8-43c2-6cc3adb901f8@linaro.org> Date: Wed, 22 Mar 2023 22:42:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add imx8qm cdns3 glue bindings Content-Language: en-US To: Frank Li Cc: "devicetree@vger.kernel.org" , "festevam@gmail.com" , "imx@lists.linux.dev" , "kernel@pengutronix.de" , "krzysztof.kozlowski+dt@linaro.org" , "linux-arm-kernel@lists.infradead.org" , dl-linux-imx , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" References: <20230321151951.2784286-1-Frank.Li@nxp.com> <20230321151951.2784286-2-Frank.Li@nxp.com> <1ce3bf91-6bef-b4c1-1ec9-3a345518efeb@linaro.org> <835cda64-5d42-1ff3-aa8f-0802fe3d705f@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/03/2023 22:40, Frank Li wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Wednesday, March 22, 2023 4:38 PM >> To: Frank Li >> Cc: devicetree@vger.kernel.org; festevam@gmail.com; imx@lists.linux.dev; >> kernel@pengutronix.de; krzysztof.kozlowski+dt@linaro.org; linux-arm- >> kernel@lists.infradead.org; dl-linux-imx ; linux- >> kernel@vger.kernel.org; robh+dt@kernel.org; s.hauer@pengutronix.de; >> shawnguo@kernel.org >> Subject: Re: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add >> imx8qm cdns3 glue bindings >> >> Caution: EXT Email >> >> On 22/03/2023 22:36, Frank Li wrote: >>> >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski >>>> Sent: Wednesday, March 22, 2023 4:32 PM >>>> To: Frank Li >>>> Cc: devicetree@vger.kernel.org; festevam@gmail.com; >> imx@lists.linux.dev; >>>> kernel@pengutronix.de; krzysztof.kozlowski+dt@linaro.org; linux-arm- >>>> kernel@lists.infradead.org; dl-linux-imx ; linux- >>>> kernel@vger.kernel.org; robh+dt@kernel.org; s.hauer@pengutronix.de; >>>> shawnguo@kernel.org >>>> Subject: Re: [EXT] Re: [PATCH v3 1/3] dt-bindings: usb: cdns-imx8qm: add >>>> imx8qm cdns3 glue bindings >>>> >>>> Caution: EXT Email >>>> >>>> On 22/03/2023 15:34, Frank Li wrote: >>>>> >>>>> >>>>>> -----Original Message----- >>>>>> From: Krzysztof Kozlowski >>>>>> Sent: Wednesday, March 22, 2023 2:32 AM >>>>>> To: Frank Li >>>>>> + - const: usb3_aclk >>>>>>> + - const: usb3_ipg_clk >>>>>>> + - const: usb3_core_pclk >>>>>>> + >>>>>>> + assigned-clocks: >>>>>>> + items: >>>>>>> + - description: Phandle and clock specifoer of >>>>>> IMX_SC_PM_CLK_MST_BUS. >>>>>> >>>>>> Drop useless pieces so "Phandle and clock specifoer of " and name the >>>>>> hardware, not the syntax. >>>>>> >>>>>>> + >>>>>>> + assigned-clock-rates: >>>>>>> + items: >>>>>>> + - description: Should be in Range 100 - 600 Mhz. >>>>>> >>>>>> That's better but I still do not understand why do you need it in the >>>>>> bindings. You never actually answered this question. >>>>> >>>>> I am not sure 100% sure the reason. >>>>> I think difference system target's axi bus frequency is difference, >>>>> And just one time work, needn't software to manage it. >>>>> Following other driver's code style may be another reason. >>>> >>>> That's the reason of heaving it in DTS. But I am asking about bindings. >>>> You do understand you define here interface? >>> >>> I defined here is descript AXI frequency for usb controller. Supposed >> difference >>> Platform will have difference working frequency. >> >> I don't understand how does this answer my concerns of having it in DT >> bindings. If you do not add it, you "will have difference working >> frequency", so what's the point? > > For example: imx8qxp, it need set to 250Mhz, i.MX8QM need set to 200Mhz. > Maybe future chip can set to 400Mhz. And? So as you can see you will still have different frequencies, so what's the point? What is the benefit? Dunno, maybe we do not understand each other, because I don't think you are answering my questions at all. Best regards, Krzysztof