From: Andrew Lunn <andrew@lunn.ch>
To: "Michal Vokáč" <michal.vokac@ysoft.com>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
"Marek Behún" <kabel@kernel.org>,
"Christian Lamparter" <chunkeey@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
petr.benes@ysoft.com
Subject: Re: [PATCH net v2] net: dsa: qca8k: fix illegal usage of GPIO
Date: Thu, 25 Jan 2024 17:59:06 +0100 [thread overview]
Message-ID: <2477cf4a-6824-4997-aef8-3f8e5f9b2399@lunn.ch> (raw)
In-Reply-To: <1706096225-23468-1-git-send-email-michal.vokac@ysoft.com>
> diff --git a/drivers/net/dsa/qca/qca8k-8xxx.c b/drivers/net/dsa/qca/qca8k-8xxx.c
> index ec57d9d52072..3663de8f2617 100644
> --- a/drivers/net/dsa/qca/qca8k-8xxx.c
> +++ b/drivers/net/dsa/qca/qca8k-8xxx.c
> @@ -2037,13 +2037,11 @@ qca8k_sw_probe(struct mdio_device *mdiodev)
> priv->dev = &mdiodev->dev;
> priv->info = of_device_get_match_data(priv->dev);
>
> - priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset",
> - GPIOD_ASIS);
> + priv->reset_gpio = devm_gpiod_get_optional(priv->dev, "reset", GPIOD_OUT_HIGH);
Sorry, i should of pointed this out on the previous version. netdev
kept with 80 character lines. That is why what you deleted was split
over two lines, and what you add should also split at the same point.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2024-01-25 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 11:37 Michal Vokáč
2024-01-25 16:59 ` Andrew Lunn [this message]
2024-01-26 10:14 ` Michal Vokáč
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2477cf4a-6824-4997-aef8-3f8e5f9b2399@lunn.ch \
--to=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petr.benes@ysoft.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®