From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755147AbcBZUKj (ORCPT <rfc822;w@1wt.eu>);
	Fri, 26 Feb 2016 15:10:39 -0500
Received: from mout.kundenserver.de ([212.227.126.133]:56615 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754165AbcBZUKi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 26 Feb 2016 15:10:38 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Lada Trimasova <Lada.Trimasova@synopsys.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
        Noam Camus <noamc@ezchip.com>, Tal Zilcer <talz@ezchip.com>
Subject: Re: [PATCH] net: ezchip: adapt driver to little endian architecture
Date: Fri, 26 Feb 2016 21:10:31 +0100
Message-ID: <24793363.yg41IbJKTo@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1456513509-30844-1-git-send-email-ltrimas@synopsys.com>
References: <1456513509-30844-1-git-send-email-ltrimas@synopsys.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:B//emJucDGazOwcZa0k8sVL84naEy/Z6PLI3275TOBvtHHZyf0t
 GG7HqSvRF4mRIGGfoFe76ZZMqoHIOFx32/CiWipjL9cFa2aJiM8+zSLIFlDHTaECBiB1B8x
 sYj4y+ytf/jtJIINUPtzGv/NMR7Z11Zhm9qo5HU+xmvytvPcn1NkbJjqBx7S0iflf83slxd
 qWizA9M0mEGnMxyhrBj7w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:IpK6ld3lGNQ=:LRC+dXR6RdWPb9CwwVg4ud
 W9AUEV6/TnQF7N3onZMd671aYBnxQ5PXgdyt1z2LnJ5MfPD+HT62gnsoxIx7rfBGWyvvBVQgU
 lI66P2ZLhoP61nWtaTvazQRlh4ytlK2RuCM0F80hYtGb+3LZJIGBrDVgAogw1/w4pRD98i5KA
 TWyuyj8NQP0uHEhm9Q2BiEWqXiSGfS8YSUrqwQ9acNXyPoe6CH/uD1Ip3Iip1EfY5xXBr+kpy
 cdCfWiQi8ebsd6GcvjTZUGKHzS4JQjjArTC5zk1LXVbCILUUTQf8AjmDJq7WKCjubdvLvcC38
 I0E1Bl1qVtMy/jcS4mT08SMq9qMF5PTj9lNm9vQJNtmuXwb+vgtPbXcs0uETu8AU14G09ELjU
 mSQz5KWBogIA6iBJW05CWPcDQiGnLG6tBSiJIJlyPPIn1bssbWrtUbWnonNCzmG6tWbySBlhd
 +R8qnhSJNwPJljxY29xiUYa19Vqk6gTOwafEQ66cmKYyNAhh9wLy+noY4ibjGk03CaHKfFe0F
 um1D2nfgwJuJmlARreK6+B4dT/SNzcJwbdI88/MkiQJcx4ARGND/xLhCQfvzUy4j5ESl+aQZy
 26/dKLDo+wYd8L9BKyqp0CjBQmTpTuYH2PCF5DTZAdbHOYPg7/QVe5UnwB+kQ8wlqDp18JoGA
 sEMGC4CdO2Zw6N6KbDicVgwCj/0FmoLe3ImBZWt2BdhWDAcTeWNTj7DM1kFzDtkhmzREOiaCl
 L7SZn9EbcS3jKsxR
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday 26 February 2016 22:05:09 Lada Trimasova wrote:
>                 for (i = 0; i < len; i++, reg++) {
>                         u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF);
> +                       buf = be32_to_cpu(buf);
>                         put_unaligned(buf, reg);
>                 }

I think most of the changes can make use of the put_unaligned_be32()
etc helpers that might also be more efficient.

	Arnd