From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: shuox.liu@intel.com
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
pavel@ucw.cz, len.brown@intel.com, gregkh@linuxfoundation.org,
yanmin_zhang@linux.intel.com
Subject: Re: [PATCH 0/2] Run callback of device_prepare/complete consistently
Date: Fri, 07 Jun 2013 12:36:12 +0200 [thread overview]
Message-ID: <2482951.doztFClhed@vostro.rjw.lan> (raw)
In-Reply-To: <1370593232-3602-1-git-send-email-shuox.liu@intel.com>
On Friday, June 07, 2013 04:20:30 PM shuox.liu@intel.com wrote:
> dpm_run_callback is used in other stages of power states changing.
> It provides debug info message and time measurement when call these
> callback. We also want to benefit ->prepare and ->complete.
>
> [PATCH 1/2] PM: use dpm_run_callback in device_prepare
> [PATCH 2/2] PM: add dpm_run_callback_void and use it in device_complete
Is this an "Oh, why don't we do that?" series, or is it useful for anything
in practice? I'm asking, because we haven't added that stuff to start with
since we didn't see why it would be useful to anyone.
And while patch [1/2] reduces the code size (by 1 line), so I can see some
(tiny) benefit from applying it, patch [2/2] adds more code and is there any
paractical reason?
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-06-07 10:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 8:20 shuox.liu
2013-06-07 8:20 ` [PATCH 1/2] PM: use dpm_run_callback in device_prepare shuox.liu
2013-06-07 17:37 ` Greg KH
2013-06-08 0:43 ` Yanmin Zhang
2013-06-08 1:15 ` Greg KH
2013-06-08 1:21 ` Yanmin Zhang
2013-06-07 8:20 ` [PATCH 2/2] PM: add dpm_run_callback_void and use it in device_complete shuox.liu
2013-06-07 17:38 ` Greg KH
2013-06-07 10:36 ` Rafael J. Wysocki [this message]
2013-06-08 0:42 ` [PATCH 0/2] Run callback of device_prepare/complete consistently Yanmin Zhang
2013-06-08 0:54 ` Rafael J. Wysocki
2013-06-08 1:17 ` Yanmin Zhang
2013-06-08 1:25 ` Rafael J. Wysocki
2013-06-08 1:16 ` Greg KH
2013-06-08 1:30 ` Rafael J. Wysocki
2013-06-08 1:36 ` Yanmin Zhang
2013-06-08 1:52 ` Rafael J. Wysocki
2013-06-08 2:37 ` Yanmin Zhang
2013-06-08 10:54 ` Rafael J. Wysocki
2013-06-09 8:11 ` ShuoX Liu
2013-06-08 1:30 ` Yanmin Zhang
2013-06-10 11:50 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2482951.doztFClhed@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=shuox.liu@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®