From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Vishnu Pratap Singh <vishnu.ps@samsung.com>
Cc: akpm@linux-foundation.org, len.brown@intel.com, pavel@ucw.cz,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
cpgs@samsung.com, pintu.k@samsung.com, vishu13285@gmail.com
Subject: Re: [PATCH] [kernel]: process: replace printk with pr_err
Date: Thu, 16 Oct 2014 10:37:50 +0200 [thread overview]
Message-ID: <2484936.7PAAKpDVM2@vostro.rjw.lan> (raw)
In-Reply-To: <1413435995-32317-1-git-send-email-vishnu.ps@samsung.com>
On Thursday, October 16, 2014 10:36:35 AM Vishnu Pratap Singh wrote:
> This patch replaces printk(KERN_ERR...) with pr_err found.
What is the reason? Does the existing code cause any problems to happen?
> Signed-off-by: Vishnu Pratap Singh <vishnu.ps@samsung.com>
> ---
> kernel/power/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 7b32322..401f7ee 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -85,7 +85,7 @@ static int try_to_freeze_tasks(bool user_only)
>
> if (todo) {
> printk("\n");
> - printk(KERN_ERR "Freezing of tasks %s after %d.%03d seconds "
> + pr_err("Freezing of tasks %s after %d.%03d seconds "
> "(%d tasks refusing to freeze, wq_busy=%d):\n",
> wakeup ? "aborted" : "failed",
> elapsed_msecs / 1000, elapsed_msecs % 1000,
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-10-16 8:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[kernel]: process: replace printk with pr_err>
2014-10-16 5:06 ` Vishnu Pratap Singh
2014-10-16 8:37 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2484936.7PAAKpDVM2@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=akpm@linux-foundation.org \
--cc=cpgs@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=pintu.k@samsung.com \
--cc=vishnu.ps@samsung.com \
--cc=vishu13285@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®