From: Jiri Slaby <jslaby@suse.cz>
To: Gregory CLEMENT <gregory.clement@bootlin.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/3] tty: n_gsm: Fix SOF skipping
Date: Mon, 4 May 2020 08:39:03 +0200 [thread overview]
Message-ID: <2484f5ee-a88d-9beb-231c-fdd307fc3400@suse.cz> (raw)
In-Reply-To: <20200430113433.2162886-3-gregory.clement@bootlin.com>
On 30. 04. 20, 13:34, Gregory CLEMENT wrote:
> For at least some modems like the TELIT LE910, skipping SOF makes
> transfers blocking indefinitely after a short amount of data
> transferred.
>
> Given the small improvement provided by skipping the SOF (just one
> byte on about 100 bytes), it seems better to completely remove this
> "feature" than make it optional.
>
> Fixes: 96fd7ce58ffb ("TTY: create drivers/tty and move the tty core files there")
Again, this is unlikely a correct "fixes" commit.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2020-05-04 6:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 11:34 [PATCH 0/3] TTY improve n_gsm support Gregory CLEMENT
2020-04-30 11:34 ` [PATCH 1/3] tty: n_gsm: Improve debug output Gregory CLEMENT
2020-05-04 6:37 ` Jiri Slaby
2020-04-30 11:34 ` [PATCH 2/3] tty: n_gsm: Fix SOF skipping Gregory CLEMENT
2020-05-04 6:39 ` Jiri Slaby [this message]
2020-04-30 11:34 ` [PATCH 3/3] tty: n_gsm: Fixe waking up upper tty layer when room available Gregory CLEMENT
2020-04-30 11:34 ` [PATCH 3/3] tty: n_gsm: Fix " Gregory CLEMENT
2020-05-04 6:30 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2484f5ee-a88d-9beb-231c-fdd307fc3400@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®