From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933080AbbKMQ14 (ORCPT ); Fri, 13 Nov 2015 11:27:56 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:60190 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932281AbbKMQ1z (ORCPT ); Fri, 13 Nov 2015 11:27:55 -0500 From: Arnd Bergmann To: Mathieu Poirier Cc: "linux-arm-kernel@lists.infradead.org" , Greg KH , a.p.zijlstra@chello.nl, Alexander Shishkin , Arnaldo Carvalho de Melo , Ingo Molnar , Jon Corbet , Nicolas Pitre , Al Grant , =?utf-8?B?UGF3ZcWC?= Moll , linux-doc@vger.kernel.org, "linux-kernel@vger.kernel.org" , fainelli@broadcom.com, Adrian Hunter , "Jeremiassen, Tor" , Mike Leach , Chunyan Zhang Subject: Re: [PATCH V3 02/26] coresight: etm3x: moving sysFS entries to dedicated file Date: Fri, 13 Nov 2015 17:26:52 +0100 Message-ID: <24873197.N72CP7Wh3q@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1447280296-19147-1-git-send-email-mathieu.poirier@linaro.org> <4446604.iDni9pkfpc@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:j6oj6qZ56PSlY13VSHvDsURryOi9zsrvz/rWT4OpmCcM8ovOkMo 8sD4kE+YsJahSfbt+uxYmYfgeFnteC2Ren8Fch5MnZHdjgsGd+W1WjUBWHG69XLOz+J8c16 EM5BQ2kETjT9AGUDge+NdsirPJt6j9T3g2ncmXxsBNqY8PuzmMkXXL56NKazRbufSYBJUOg edAcM1k9EiL9BhP9+kq9Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:mWnjCSqCwHg=:FXRQhQdRJfhLP88AoieCQU lC9KkxcK4NVGuO6Nja61mrsRqwuFL1vWEWfwjFcgL+1PR4LlOJreP9ws01ov0xZVQfw/WWkGZ YH06AkXS+7k0UfweCbxhcIEoBOPdtV+Jd4f2AMfOmLB2821LNGahZ724nK3ZRg3PAMFV+z/gK 1YX4YVo9ysz9WxLdykOeEdYEwPa1QBtZ8L0Lbrad0NTTimPTtwVVWf3rNJTs5/F19/+QIarhp Jmki4UnkKJqPr4nvDtLBKgDLv0DhPkNfuOEZP2x1wWS9tdco4MrMsKJXJYprxU9dajFeglhpJ FAFMSEwDjJJJmTCUCnKXPmgQ7ap1XGahLzcjeO3/5U5FJuEdPSr8ZzlRRPMggL9PiqWy3qQrn 1yz1VTYoa3WzW5YOEH8P3zGhAazIl9DLYtxkX5oRH3SacjX/G9mJ6n5tLDN8EjpvsKBLZa7VR AZDyWlx4R2ETzSvs7yG1H7OwEH8lF7w4oebPX3GCR9nWrpP+L76kV5RCkQ+Jgz8mFvfWPGzKe pEWpybvmRUYiF5VnlyFijiGXa5hLTWMpAzncByq8jRJFVOAA+UNZDqFiJbhEdTUXjL92pu103 cQbPhZ9El72FZHwu+RW95mv27PQIIyfIInnDYz9X5yY/vXUdeRqQUPxVIeMdudVCH2/A0sySw yzlkgB0unEnK67jWfuBjR7icrzksztuFtPKp3rMPONDlLoY3fE/RO23/TjIcfL1p+6upvV3p7 R2MJ9OqmjwUqzfGT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 13 November 2015 09:17:18 Mathieu Poirier wrote: > On 11 November 2015 at 15:30, Arnd Bergmann wrote: > > On Wednesday 11 November 2015 15:17:52 Mathieu Poirier wrote: > >> SysFS entries are big enough to justify their own file. > >> As such moving all sysFS related declarations to a dedicated > >> location. > >> > >> Signed-off-by: Mathieu Poirier > >> --- > >> drivers/hwtracing/coresight/Makefile | 3 +- > >> drivers/hwtracing/coresight/coresight-etm.h | 4 + > >> .../hwtracing/coresight/coresight-etm3x-sysfs.c | 1218 +++++++++++++++++++ > >> drivers/hwtracing/coresight/coresight-etm3x.c | 1234 +------------------- > >> > > > > You are adding a lot of interfaces here, make sure that each one is documented > > in Documentation/ABI/. > > Everything is documented in > Documentation/ABI/testing/sysfs-bus-coresight-devices-etm3x. > > > > > Your patch series doesn't add anything here, are you just using an existing > > ABI? > > That is correct. Ok, excellent. I failed to see that all the implementations are just moved from one file to another, should really have read the patch description better. Arnd