From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965237AbcBDKmj (ORCPT ); Thu, 4 Feb 2016 05:42:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53507 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964773AbcBDKme (ORCPT ); Thu, 4 Feb 2016 05:42:34 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <56B314E5.5000000@hpe.com> References: <56B314E5.5000000@hpe.com> <1454145497-4567-1-git-send-email-juerg.haefliger@hpe.com> <13368.1454531662@warthog.procyon.org.uk> To: Juerg Haefliger Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org, dwmw2@infradead.org Subject: Re: [PATCH] scripts/sign-file.c: Add support for signing with a raw signature MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24879.1454582552.1@warthog.procyon.org.uk> Date: Thu, 04 Feb 2016 10:42:32 +0000 Message-ID: <24880.1454582552@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Juerg Haefliger wrote: > >> +static EVP_PKEY *read_private_key(char *private_key_name) > > > > const char * please. > > > >> +static X509 *read_x509(char *x509_name) > > > > And here. > > Why? These functions do return pointers to EVP_PKEY and X509 structs. I meant the arguments not the return type. David