From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1760319AbdAKVOU (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Jan 2017 16:14:20 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:55976 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756490AbdAKVNh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jan 2017 16:13:37 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Robin Murphy <robin.murphy@arm.com>, Will Deacon <will.deacon@arm.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-renesas-soc@vger.kernel.org, Simon Horman <horms@verge.net.au>,
        Bjorn Helgaas <bhelgaas@google.com>, fkan@apm.com,
        linux-kernel@vger.kernel.org,
        Artemi Ivanov <artemi.ivanov@cogentembedded.com>
Subject: Re: [PATCH 2/2] arm64: avoid increasing DMA masks above what hardware supports
Date: Wed, 11 Jan 2017 22:11:32 +0100
Message-ID: <2489599.dXme8sRkvp@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1484159512-28515-3-git-send-email-nikita.yoush@cogentembedded.com>
References: <dca35acf-1adf-aa85-7a0b-d0c6ec702fa1@arm.com> <1484159512-28515-1-git-send-email-nikita.yoush@cogentembedded.com> <1484159512-28515-3-git-send-email-nikita.yoush@cogentembedded.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:ssgC7VFIpFQNkBbBfpJbRqtAJOG3NMkFfxr4TayXk7kZa2Q37Qw
 G6Gvm8ROQ2yptg8MfeRfoT4bSQsSPllOJcJ6xpcEMsb7pyZPBxfhvJS2Upra4doIgKGN38o
 ersY02EkRtGGMXiS0sCrvv38l7lRRKVwQ6lJa1ZnZn9y7jDsiUszc28EhnVNw6UHeO/HWH0
 RvUazYu74dnAeLpw8qBxw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:5wFVN9jBaf0=:GTB4xBSo3j089YeFPdsIue
 Asgk+iJ+cHWR/2IONxRp4aZM75iN7yeUAKfqaBJRR9VUjaAbezFKsHCgSBdxTYkdyoCD4noD6
 QlZL7tHfrjZeZWNUJRxBDTPcHK0ryapAX9dCRYMm1Mv5diRNyCJpS0pJ/yOmmNwvyPbBv7rzD
 NNvZNX5vMALxfH4ROWNfQMaIgx66HZd7QRNUweBDzjV1jqr2JWViE43ZFEJjSFEKMAgjasZDL
 8gIKAJaGG6EzuKWHihxtWuoGfEpy60VNN5LG/H5DUWpK0TUt9Ibt8LJTaK+2Yc7+9Fve4D5Nc
 nzUXIuz8U7Mlb4J0rSN+YshZ5AhhlGh83MYqZGZ1+/YDUpGaXn0SoU/TmepLk2Y5FaPYWit0k
 AZSQKUyvlEy40YqvTKpb9YvKtsNBQf5bEOOC+MoJUNHIMi8Hcmj71xoacghh63carOQe77HTS
 vF357SJx8whNORYsG/eMW2KqT3/tAr7rM7FI1nkleVczWOFchkfzrqOobHGRpDHRCh2Xo2v2X
 giz4OdRMxas9Nepn4X7coIHcrHldD4eVshfl8tVfVBcrAmCKz2MMlH7P5sCLdLz2rbboR2FgV
 fYhmuqLKSFmnVlcEd2mQU0sDurMKslt0CaS/pogKTKm5oww1Ero5M47HDaGVXYpYID07XqHp4
 4KtJtqIavtByW+vt6bdU//7ZyIkBBOZEonP+RMSlcUbMtlXvlcPzVhhuQS115fjDz9zsifv1I
 EvL4iGNzdsUYJX/A
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wednesday, January 11, 2017 9:31:52 PM CET Nikita Yushchenko wrote:
> @@ -959,6 +990,15 @@ void arch_setup_dma_ops(struct device *dev, u64 dma_base, u64 size,
>         if (!dev->archdata.dma_ops)
>                 dev->archdata.dma_ops = &swiotlb_dma_ops;
>  
> +       /*
> +        * Whatever the parent bus can set. A device must not set
> +        * a DMA mask larger than this.
> +        */
> +       if (enforce_range)
> +               dev->archdata.parent_dma_mask = size - 1;
> +       else
> +               dev->archdata.parent_dma_mask = DMA_BIT_MASK(64);
> +
>         dev->archdata.dma_coherent = coherent;
>         __iommu_setup_dma_ops(dev, dma_base, size, iommu);
> 

Could we just pass the mask instead of the size here?

	Arnd