From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Andrei Vagin <avagin@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Dmitry Safonov <dima@arista.com>
Subject: Re: [PATCH 5/5] arm64/vdso: Restrict splitting VVAR VMA
Date: Mon, 24 Feb 2020 10:08:08 +0000 [thread overview]
Message-ID: <248ddd41-d3b3-05f2-4e49-177236726209@arm.com> (raw)
In-Reply-To: <20200223233013.GB349924@gmail.com>
Hi Andrei,
On 2/23/20 11:30 PM, Andrei Vagin wrote:
[...]
>
> Hmmm. I have read the code of special_mapping_mremap() and I don't see where
> it restricts splitting the vvar mapping.
>
> Here is the code what I see in the source:
>
> static int special_mapping_mremap(struct vm_area_struct *new_vma)
> {
> struct vm_special_mapping *sm = new_vma->vm_private_data;
>
> if (WARN_ON_ONCE(current->mm != new_vma->vm_mm))
> return -EFAULT;
>
> if (sm->mremap)
> return sm->mremap(sm, new_vma);
>
> return 0;
> }
>
> And I have checked that without this patch, I can remap only one page of
> the vvar mapping.
>
I checked it a second time and I agree. The check on new_size is required in
this case.
> Thanks,
> Andrei
>
--
Regards,
Vincenzo
next prev parent reply other threads:[~2020-02-24 10:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-04 17:59 [PATCH 0/5] arm64: add the time namespace support Andrei Vagin
2020-02-04 17:59 ` [PATCH 1/5] arm64/vdso: use the fault callback to map vvar pages Andrei Vagin
2020-02-20 12:36 ` Vincenzo Frascino
2020-02-04 17:59 ` [PATCH 2/5] arm64/vdso: Zap vvar pages when switching to a time namespace Andrei Vagin
2020-02-04 17:59 ` [PATCH 3/5] arm64/vdso: Add time napespace page Andrei Vagin
2020-02-20 12:03 ` Vincenzo Frascino
2020-02-04 17:59 ` [PATCH 4/5] arm64/vdso: Handle faults on timens page Andrei Vagin
2020-02-20 12:07 ` Vincenzo Frascino
2020-02-04 17:59 ` [PATCH 5/5] arm64/vdso: Restrict splitting VVAR VMA Andrei Vagin
2020-02-20 12:22 ` Vincenzo Frascino
2020-02-23 23:30 ` Andrei Vagin
2020-02-24 10:08 ` Vincenzo Frascino [this message]
2020-02-17 15:34 ` [PATCH 0/5] arm64: add the time namespace support Andrei Vagin
2020-02-17 18:25 ` Vincenzo Frascino
2020-02-20 12:40 ` Vincenzo Frascino
2020-02-23 8:08 ` Andrei Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248ddd41-d3b3-05f2-4e49-177236726209@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=avagin@gmail.com \
--cc=dima@arista.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®