From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3138C46466 for ; Mon, 5 Oct 2020 18:08:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5877720FC3 for ; Mon, 5 Oct 2020 18:08:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727445AbgJESIY (ORCPT ); Mon, 5 Oct 2020 14:08:24 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:2957 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725960AbgJESIY (ORCPT ); Mon, 5 Oct 2020 14:08:24 -0400 Received: from lhreml724-chm.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id C9FE3F895F4435A2D160; Mon, 5 Oct 2020 19:08:21 +0100 (IST) Received: from [127.0.0.1] (10.47.2.205) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Mon, 5 Oct 2020 19:08:19 +0100 Subject: Re: Issue of metrics for multiple uncore PMUs (was Re: [RFC PATCH v2 23/23] perf metricgroup: remove duped metric group events) To: Ian Rogers CC: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , Kajol Jain , Andi Kleen , Jin Yao , Kan Liang , Cong Wang , Kim Phillips , LKML , Networking , bpf , linux-perf-users , Stephane Eranian References: <20200507140819.126960-1-irogers@google.com> <20200507140819.126960-24-irogers@google.com> <757974b3-62b0-2822-84fb-1e75907c6cc4@huawei.com> From: John Garry Message-ID: <248e8d19-8727-b403-4196-59eac1b1f305@huawei.com> Date: Mon, 5 Oct 2020 19:05:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.2.205] X-ClientProxiedBy: lhreml748-chm.china.huawei.com (10.201.108.198) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/10/2020 17:28, Ian Rogers wrote: > On Mon, Oct 5, 2020 at 3:06 AM John Garry wrote: >> >> On 02/10/2020 21:46, Ian Rogers wrote: >>> On Fri, Oct 2, 2020 at 5:00 AM John Garry wrote: >>>> >>>> On 07/05/2020 15:08, Ian Rogers wrote: >>>> >>>> Hi Ian, >>>> >>>> I was wondering if you ever tested commit 2440689d62e9 ("perf >>>> metricgroup: Remove duped metric group events") for when we have a >>>> metric which aliases multiple instances of the same uncore PMU in the >>>> system? >>> >>> Sorry for this, I hadn't tested such a metric and wasn't aware of how >>> the aliasing worked. I sent a fix for this issue here: >>> https://lore.kernel.org/lkml/20200917201807.4090224-1-irogers@google.com/ >>> Could you see if this addresses the issue for you? I don't see the >>> change in Arnaldo's trees yet. >> >> Unfortunately this does not seem to fix my issue. >> >> So for that patch, you say you fix metric expression for DRAM_BW_Use, >> which is: >> >> { >> "BriefDescription": "Average external Memory Bandwidth Use for reads >> and writes [GB / sec]", >> "MetricExpr": "( 64 * ( uncore_imc@cas_count_read@ + >> uncore_imc@cas_count_write@ ) / 1000000000 ) / duration_time", >> "MetricGroup": "Memory_BW", >> "MetricName": "DRAM_BW_Use" >> }, >> >> But this metric expression does not include any alias events; rather I >> think it is just cas_count_write + cas_count_read event count for PMU >> uncore_imc / duration_time. >> >> When I say alias, I mean - as an example, we have event: >> >> { >> "BriefDescription": "write requests to memory controller. >> Derived from unc_m_cas_count.wr", >> "Counter": "0,1,2,3", >> "EventCode": "0x4", >> "EventName": "LLC_MISSES.MEM_WRITE", >> "PerPkg": "1", >> "ScaleUnit": "64Bytes", >> "UMask": "0xC", >> "Unit": "iMC" >> }, >> >> And then reference LLC_MISSES.MEM_WRITE in a metric expression: >> >> "MetricExpr": "LLC_MISSES.MEM_WRITE / duration_time", >> >> This is what seems to be broken for when the alias matches > 1 PMU. >> >> Please check this. > Hi Ian, > Happy to check. So I am, but the code is a little complicated :) > Can you provide a reproduction? Looking on broadwell > this metric doesn't exist. Right, I just added this test metric as my 2x x86 platform has no examples which I can find: diff --git a/tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json b/tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json index 8cdc7c13dc2a..fc6d9adf996a 100644 --- a/tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json +++ b/tools/perf/pmu-events/arch/x86/broadwell/bdw-metrics.json @@ -348,5 +348,11 @@ "MetricExpr": "(cstate_pkg@c7\\-residency@ / msr@tsc@) * 100", "MetricGroup": "Power", "MetricName": "C7_Pkg_Residency" + }, + { + "BriefDescription": "test metric", + "MetricExpr": "UNC_CBO_XSNP_RESPONSE.MISS_XCORE * UNC_CBO_XSNP_RESPONSE.MISS_EVICTION", + "MetricGroup": "Test", + "MetricName": "test_metric_inc" } ] I'll try to find a better mainline example, though, but I'm not hopeful ... Thanks, John