From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Fenglin Wu <fenglin.wu@oss.qualcomm.com>,
kernel@oss.qualcomm.com, Lee Jones <lee@kernel.org>,
Pavel Machek <pavel@kernel.org>
Cc: Subbaraman Narayanamurthy
<subbaraman.narayanamurthy@oss.qualcomm.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] leds: flash: leds-qcom-flash: update torch current clamp setting
Date: Thu, 31 Jul 2025 11:33:25 +0200 [thread overview]
Message-ID: <2496bdb9-2ad6-4fdb-9a35-e9b8a15d744e@oss.qualcomm.com> (raw)
In-Reply-To: <e0f827e0-1552-4542-ac70-70903227734e@oss.qualcomm.com>
On 7/31/25 3:43 AM, Fenglin Wu wrote:
>
> On 7/29/2025 7:01 PM, Konrad Dybcio wrote:
>>> + torch_clamp = (current_ua / led->chan_count) / TORCH_IRES_UA;
>>> + if (torch_clamp != 0)
>>> + torch_clamp--;
>>> +
>>> + flash_data->torch_clamp = max_t(u8, flash_data->torch_clamp, torch_clamp);
>> Please confirm if I understand correctly, we may have N flash LEDs
>> connected, and this additional safety hardware can only compare any
>> individual LED's current draw against a single maximum value, which
>> we're setting here
> Yes, your understanding is correct!
Great, thank you for confirming
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-07-31 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 4:51 [PATCH v2 0/2] " Fenglin Wu via B4 Relay
2025-07-29 4:51 ` [PATCH v2 1/2] " Fenglin Wu via B4 Relay
2025-07-29 11:01 ` Konrad Dybcio
2025-07-31 1:43 ` Fenglin Wu
2025-07-31 9:33 ` Konrad Dybcio [this message]
2025-07-29 4:51 ` [PATCH v2 2/2] leds: flash: leds-qcom-flash: add a separate register map for PMI8998 Fenglin Wu via B4 Relay
2025-07-29 11:01 ` Konrad Dybcio
2025-07-31 13:53 ` [PATCH v2 0/2] leds: flash: leds-qcom-flash: update torch current clamp setting Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2496bdb9-2ad6-4fdb-9a35-e9b8a15d744e@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=fenglin.wu@oss.qualcomm.com \
--cc=kernel@oss.qualcomm.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=subbaraman.narayanamurthy@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®