From: Paolo Bonzini <pbonzini@redhat.com>
To: Joe Perches <joe@perches.com>, linmiaohe <linmiaohe@huawei.com>,
Linus Walleij <linux.walleij@sterricsson.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: enable -Werror
Date: Thu, 13 Feb 2020 10:54:38 +0100 [thread overview]
Message-ID: <249ec0c0-10fb-52df-0c81-2ec28ecae32b@redhat.com> (raw)
In-Reply-To: <71b3bf53c0fc3c68b10368092022e3bf2cffc506.camel@perches.com>
On 13/02/20 04:31, Joe Perches wrote:
> On Thu, 2020-02-13 at 01:40 +0000, linmiaohe wrote:
>> Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> Avoid more embarrassing mistakes. At least those that the compiler can catch.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>
> I think adding -Werror is a bad idea as new versions of compilers can
> create additional compilation warnings and break builds in the
> future.
Seems like cargo culting (in the reverse) to me. We can cross the
bridge when we get there.
Paolo
next prev parent reply other threads:[~2020-02-13 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 1:40 linmiaohe
2020-02-13 3:31 ` Joe Perches
2020-02-13 9:54 ` Paolo Bonzini [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-12 19:20 Paolo Bonzini
2020-02-20 13:44 ` Vitaly Kuznetsov
2020-02-20 19:39 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=249ec0c0-10fb-52df-0c81-2ec28ecae32b@redhat.com \
--to=pbonzini@redhat.com \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.walleij@sterricsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome