From: Stefano Radaelli <stefano.radaelli21@gmail.com>
To: Frank Li <Frank.Li@nxp.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Cc: pierluigi.p@variscite.com,
Stefano Radaelli <stefano.r@variscite.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Shawn Guo <shawnguo@kernel.org>, Joseph Guo <qijian.guo@nxp.com>,
Josua Mayer <josua@solid-run.com>,
Ernest Van Hoecke <ernest.vanhoecke@toradex.com>,
Mehmet Fide <mehmet.fide@screeningeagle.com>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
Markus Niebel <Markus.Niebel@ew.tq-group.com>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
Stefan Eichenberger <eichest@gmail.com>,
netdev@vger.kernel.org
Subject: [PATCH v4 04/13] net: phy: micrel: Check RMII clock select property presence
Date: Tue, 29 Sep 2026 17:17:31 +0200 [thread overview]
Message-ID: <249f29ecae7cf9dbbeb9691df2c67e4f0cfe326f.1790693249.git.stefano.r@variscite.com> (raw)
In-Reply-To: <cover.1790693249.git.stefano.r@variscite.com>
From: Stefano Radaelli <stefano.r@variscite.com>
The micrel,rmii-reference-clock-select-25-mhz property is tested
for presence, but of_property_read_bool() warns when the property
has a value. Encoding it as <1> to satisfy the DT schema unit check
would therefore produce a warning at PHY probe.
Use of_property_present() for the presence test. It accepts both
existing empty properties and the new numeric form without changing
the RMII clock selection.
Signed-off-by: Stefano Radaelli <stefano.r@variscite.com>
---
v2->v3:
- New patch: use of_property_present() for the RMII clock select
property so its numeric form does not warn during PHY probe.
drivers/net/phy/micrel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index ae830781824b..acb481a29c25 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -2791,7 +2791,7 @@ static int kszphy_probe(struct phy_device *phydev)
if (type)
priv->rmii_ref_clk_sel = type->has_rmii_ref_clk_sel;
- rmii_ref_clk_sel_25_mhz = of_property_read_bool(np,
+ rmii_ref_clk_sel_25_mhz = of_property_present(np,
"micrel,rmii-reference-clock-select-25-mhz");
if (rate > 24500000 && rate < 25500000) {
--
2.47.3
next prev parent reply other threads:[~2026-09-29 15:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 15:17 [PATCH v4 00/13] ARM: dts: imx6ul: Add Variscite VAR-SOM-6UL and DART-6UL Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 01/13] dt-bindings: arm: fsl: Add Variscite i.MX6UL board variants Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 02/13] dt-bindings: arm: fsl: Add Variscite i.MX6ULL " Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 03/13] dt-bindings: arm: fsl: Add Variscite i.MX6ULZ " Stefano Radaelli
2026-09-29 15:17 ` Stefano Radaelli [this message]
2026-09-29 15:17 ` [PATCH v4 05/13] dt-bindings: net: micrel: Fix RMII clock select property type Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 06/13] ARM: dts: imx6ul: Add Variscite SoM and DART base files Stefano Radaelli
2026-09-29 16:15 ` Hugo Villeneuve
2026-09-29 15:17 ` [PATCH v4 07/13] ARM: dts: imx6ul: Add Variscite audio codec files Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 08/13] ARM: dts: imx6ul: Add Variscite storage and wireless files Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 09/13] ARM: dts: imx6ul: Add Variscite carrier board files Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 10/13] ARM: dts: imx6ul: Reuse Variscite DTSI files for Concerto Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 11/13] ARM: dts: imx6ul: Add Variscite i.MX6UL board variants Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 12/13] ARM: dts: imx6ull: Add Variscite i.MX6ULL " Stefano Radaelli
2026-09-29 15:17 ` [PATCH v4 13/13] ARM: dts: imx6ulz: Add Variscite i.MX6ULZ " Stefano Radaelli
2026-09-29 16:14 ` [PATCH v4 00/13] ARM: dts: imx6ul: Add Variscite VAR-SOM-6UL and DART-6UL Hugo Villeneuve
2026-09-29 17:41 ` Stefano Radaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=249f29ecae7cf9dbbeb9691df2c67e4f0cfe326f.1790693249.git.stefano.r@variscite.com \
--to=stefano.radaelli21@gmail.com \
--cc=Frank.Li@nxp.com \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=eichest@gmail.com \
--cc=ernest.vanhoecke@toradex.com \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=hkallweit1@gmail.com \
--cc=hvilleneuve@dimonoff.com \
--cc=imx@lists.linux.dev \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mehmet.fide@screeningeagle.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pierluigi.p@variscite.com \
--cc=qijian.guo@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefano.r@variscite.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®