mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maciej Strozek <mstrozek@opensource.cirrus.com>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
	yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
	perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: SDCA: Use Function Extension info for FDL
Date: Fri, 20 Nov 2026 14:16:27 +0000	[thread overview]
Message-ID: <249f5a50ed481dc03a9f2617468136670898f9ee.camel@opensource.cirrus.com> (raw)
In-Reply-To: <av2D5PvUiopWIhFv@opensource.cirrus.com>

W dniu śro, 18.11.2026 o godzinie 10∶54 +0000, użytkownik Charles
Keepax napisał:
> On Tue, Nov 17, 2026 at 02:48:53PM +0000, Maciej Strozek wrote:
> > 
> > - disk_filename = fdl_get_sku_filename(dev, fdl_file);
> > - if (!disk_filename)
> > - return -ENOMEM;
> > + ret = fdl_get_sku_filename(interrupt, fdl_file,
> > +    &disk_filename, &fallback_filename);
> > + if (ret)
> > + return ret;
> >  
> >   dev_dbg(dev, "FDL disk filename: %s\n", disk_filename);
> 
> We should probably drop these FDL disk filename prints since the
> filename is now printed through source anyway.
> > 
Yes, in case it finds the file, but I think it might be useful to know
what it attempted to read for debugging if it fails. Would moving those
prints inside the (!swf) case be better?
> 
-- 
Regards,
Maciej

      reply	other threads:[~2026-11-20 14:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:48 Maciej Strozek
2026-11-18 10:54 ` Charles Keepax
2026-11-20 14:16   ` Maciej Strozek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=249f5a50ed481dc03a9f2617468136670898f9ee.camel@opensource.cirrus.com \
    --to=mstrozek@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®