From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbbJJVkP (ORCPT ); Sat, 10 Oct 2015 17:40:15 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:37334 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751178AbbJJVkN convert rfc822-to-8bit (ORCPT ); Sat, 10 Oct 2015 17:40:13 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.0 \(3094\)) Subject: Re: [PATCH] vme: tsi148: silence uninitialized variable warning From: Dmitry Kalinkin In-Reply-To: Date: Sat, 10 Oct 2015 17:40:08 -0400 Cc: Greg Kroah-Hartman , Manohar Vanga , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <24E25954-7F91-436E-8656-5D92CA79079B@gmail.com> References: <1444017557-27296-1-git-send-email-dmitry.kalinkin@gmail.com> To: Martyn Welch X-Mailer: Apple Mail (2.3094) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martyn, Sorry, your comment is too late. This patch is already in staging-next. Dmitri > On 2015/10/10, at 17:35, Martyn Welch wrote: > > On 5 October 2015 at 04:59, Dmitry Kalinkin wrote: >> The warning is a false positive. >> > > That seems very likely. > > Please could you role this into the original patch (vme: change bus > error handling scheme)? > > Martyn > >> drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write': >> drivers/vme/bridges/vme_tsi148.c:1358:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized] >> vme_unregister_error_handler(handler); >> ^ >> drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_read': >> drivers/vme/bridges/vme_tsi148.c:1260:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized] >> vme_unregister_error_handler(handler); >> ^ >> >> Fixes: 0b0496625715 ("vme: change bus error handling scheme") >> Signed-off-by: Dmitry Kalinkin >> --- >> drivers/vme/bridges/vme_tsi148.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/vme/bridges/vme_tsi148.c b/drivers/vme/bridges/vme_tsi148.c >> index d1e383b..6052483 100644 >> --- a/drivers/vme/bridges/vme_tsi148.c >> +++ b/drivers/vme/bridges/vme_tsi148.c >> @@ -1186,7 +1186,7 @@ static ssize_t tsi148_master_read(struct vme_master_resource *image, void *buf, >> int retval, enabled; >> unsigned long long vme_base, size; >> u32 aspace, cycle, dwidth; >> - struct vme_error_handler *handler; >> + struct vme_error_handler *handler = NULL; >> struct vme_bridge *tsi148_bridge; >> void __iomem *addr = image->kern_base + offset; >> unsigned int done = 0; >> @@ -1276,7 +1276,7 @@ static ssize_t tsi148_master_write(struct vme_master_resource *image, void *buf, >> unsigned int done = 0; >> unsigned int count32; >> >> - struct vme_error_handler *handler; >> + struct vme_error_handler *handler = NULL; >> struct vme_bridge *tsi148_bridge; >> struct tsi148_driver *bridge; >> >> -- >> 1.8.3.1 >>