From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73B8523394B for ; Sat, 27 Jun 2026 12:03:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782561801; cv=none; b=dnZz72HNcxMp9hw0bborSgDXpzm3rtOVfwwF2TJ+RHfnspk0FRt2U+1Ko0kyv7Bx5xQln1bZ3Dby89ZxzTHDt6ErxHeR3djqwFuYUDIdvDchhm2/Ayqkf0Ff7hGxw59LAtKGxMUGLPgia0TaAKPgjRZfEl207UKZ5DqVd2/6ud8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782561801; c=relaxed/simple; bh=WwGFokztcs+y9n4jJTNDSzVxZhLEu2f8nljUSlA7JXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lzq7rHm0vjTIvQ0c9yw35WG+0WR8eR/VtE6MbxUxdDcOu6P+/YmJp3hTDlwAMVkloBsLPPxd0GVP4TsJNJQd32+9FBOo88GOLN0oCm6C0xxKsRLqPt6hbjGym4ecK5myJre4DlyaJU57oKYMs1bRHy2IQF5OZon0H/ZNFgrYTVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=MZr0qSpd; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="MZr0qSpd" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 7092C4E409FE; Sat, 27 Jun 2026 12:03:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 24CE760233; Sat, 27 Jun 2026 12:03:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 6ED60106F0447; Sat, 27 Jun 2026 14:03:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782561791; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=vXHW0KlN3ToKmF2y5q+w/EnLPad1QSe+5reRgFv7LEA=; b=MZr0qSpduLDgGneJuPXUW3tm3Wox0CLWrXJ1dd7bgqRTuZxb3bpcWYT2RyQGt3a0ZuvlfD 5XNMmDD52JQ7UkdP0eKxjDa98a83ohEUb8R19UWODqH5NvRT9z69KwB2mr4oIt05bC/Mzb jrIXZmQ9vbjVm5GM1qeNWJpdI+HLcblpXXC2drJEIaZCzJrc4DVsA3VGyCAOXFmLHxXcjm mCHogqiRU6zGtlp7bWNM3NAVmvb3lv0vNAYChJCZbYcccjST6thpfW+J/ORfkbQWfdQybm IDTdj64W5CESXBeX5pPf3kKfZWctIAE3fiygR5IN5VhX7YlD9ne9EzLsJ3x6Ag== Message-ID: <24a4065d-1e37-4364-94eb-622b11bd0471@bootlin.com> Date: Sat, 27 Jun 2026 14:03:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v4 2/2] net: phy: mdio-i2c: defer RollBall bridge probe to PHY discovery To: Petr Wozniak , olek2@wp.pl, linux@armlinux.org.uk, andrew@lunn.ch, hkallweit1@gmail.com Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, bjorn@mork.no, kabel@kernel.org References: <20260624084814.20972-3-petr.wozniak@gmail.com> <20260626163519.10678-1-petr.wozniak@gmail.com> From: Maxime Chevallier Content-Language: en-US In-Reply-To: <20260626163519.10678-1-petr.wozniak@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi Petr On 6/26/26 18:35, Petr Wozniak wrote: > Maxime Chevallier wrote: >> I finally got time to test this with a RollBall module, and I >> confirm what Aleksander says, the RollBall module's PHY doesn't >> get detected even with this patch. It does work on v7.0 though, >> so before the bridge probing was introduced. > > Thanks a lot for taking the time to test, Maxime - and Aleksander > for the original report. > > That settles it: the deferred-probe approach in patch 2/2 doesn't > actually restore genuine RollBall PHY detection, and as you both > confirm it worked before 8fe125892f40 introduced the bridge probing. > Sashiko's static review flagged the same thing (the probe bypasses the > PHY discovery retry loop for slow-initializing modules), so the static > analysis and the two hardware reports all point at the same flaw. > > I only have RTL8261BE-based copper modules here, not a genuine RollBall > one, so I can't develop and verify a proper slow-init timing fix > (module_t_wait / a retry that waits for the bridge) without the > hardware to test against. > > Given that, my suggestion: > > - Please drop patch 2/2 from the series. > > - Since 8fe125892f40 regressed genuine RollBall detection and the > deferred probe doesn't restore it, I think the cleanest fix is to > revert 8fe125892f40. I'm happy to send that revert if you'd prefer. > The 5-minute RTL8261BE probe loop it was addressing is handled in our > downstream tree, so reverting it upstream is fine on our side. > > - Patch 1/2 (the mii_bus leak fix) is independent of all this and > already has Reviewed-by from Maxime and Larysa - it would be good to > take that one regardless. I can resend it standalone if that's easier. > > A proper fix covering slow-firmware modules really needs a genuine > RollBall module to validate, so it's better owned by someone who has > that hardware - happy to help review. > I only have a single rollball module here, and none with the missing bridge, so I can't test the full thing either. In that case, I agree with reverting 8fe125892f40 as this is breaking all rollball modules right now. Can you send the revert ? Maxime