From: "Maíra Canal" <mcanal@igalia.com>
To: Louis Chauvet <louis.chauvet@bootlin.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Melissa Wen <melissa.srw@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net,
linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com,
miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com,
seanpaul@google.com, marcheu@google.com,
nicolejadeyee@google.com
Subject: Re: [PATCH 1/3] drm/vkms: Formatting and typo fix
Date: Thu, 15 Aug 2024 11:05:27 -0300 [thread overview]
Message-ID: <24a660e1-0f59-4214-96c1-aab29b266be4@igalia.com> (raw)
In-Reply-To: <20240814-google-clarifications-v1-1-3ee76d7d0c28@bootlin.com>
On 8/14/24 05:46, Louis Chauvet wrote:
> Some newlines were missing around comments.
>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
Applied to drm/misc/drm-misc-next!
Best Regards,
- Maíra
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 6860bee8e981..5aeb43592960 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -163,9 +163,11 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> dev->mode_config.max_height = YRES_MAX;
> dev->mode_config.cursor_width = 512;
> dev->mode_config.cursor_height = 512;
> - /* FIXME: There's a confusion between bpp and depth between this and
> + /*
> + * FIXME: There's a confusion between bpp and depth between this and
> * fbdev helpers. We have to go with 0, meaning "pick the default",
> - * which ix XRGB8888 in all cases. */
> + * which is XRGB8888 in all cases.
> + */
> dev->mode_config.preferred_depth = 0;
> dev->mode_config.helper_private = &vkms_mode_config_helpers;
>
>
next prev parent reply other threads:[~2024-08-15 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 8:46 [PATCH 0/3] drm/vkms: Miscelanious clarifications Louis Chauvet
2024-08-14 8:46 ` [PATCH 1/3] drm/vkms: Formatting and typo fix Louis Chauvet
2024-08-15 14:05 ` Maíra Canal [this message]
2024-08-14 8:46 ` [PATCH 2/3] drm/vkms: Rename index to possible_crtc Louis Chauvet
2024-08-15 14:07 ` Maíra Canal
2024-08-26 16:22 ` Louis Chauvet
2024-08-14 8:47 ` [PATCH 3/3] drm/vkms: Add documentation Louis Chauvet
2024-08-15 14:30 ` Maíra Canal
2024-08-19 15:07 ` José Expósito
2024-08-29 13:36 ` Louis Chauvet
2024-08-15 14:02 ` [PATCH 0/3] drm/vkms: Miscelanious clarifications Maíra Canal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a660e1-0f59-4214-96c1-aab29b266be4@igalia.com \
--to=mcanal@igalia.com \
--cc=airlied@gmail.com \
--cc=arthurgrillo@riseup.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=jeremie.dautheribes@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcheu@google.com \
--cc=melissa.srw@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=nicolejadeyee@google.com \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=seanpaul@google.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®