From: Mark Brown <broonie@kernel.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>,
Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] kselftest/arm64/gcs: Correctly check return value when disabling GCS
Date: Thu, 21 Aug 2025 18:08:13 +0100 [thread overview]
Message-ID: <24a68b5d-2c24-46ec-aee2-74b45b45deea@sirena.org.uk> (raw)
In-Reply-To: <20250821-nolibc-gcs-fixes-v1-1-88519836c915@weissschuh.net>
[-- Attachment #1: Type: text/plain, Size: 211 bytes --]
On Thu, Aug 21, 2025 at 05:13:02PM +0200, Thomas Weißschuh wrote:
> The return value was not assigned to 'ret', so the check afterwards
> does not do anything.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-08-21 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 15:13 [PATCH 0/2] kselftest/arm64/gcs: Cleanups for basic-gcs.c Thomas Weißschuh
2025-08-21 15:13 ` [PATCH 1/2] kselftest/arm64/gcs: Correctly check return value when disabling GCS Thomas Weißschuh
2025-08-21 17:08 ` Mark Brown [this message]
2025-08-21 15:13 ` [PATCH 2/2] kselftest/arm64/gcs: Use nolibc's getauxval() Thomas Weißschuh
2025-08-21 17:24 ` Mark Brown
2025-09-08 15:55 ` [PATCH 0/2] kselftest/arm64/gcs: Cleanups for basic-gcs.c Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a68b5d-2c24-46ec-aee2-74b45b45deea@sirena.org.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=shuah@kernel.org \
--cc=thiago.bauermann@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®