mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Vivek Gautam'" <gautamvivek1987@gmail.com>,
	"'Doug Anderson'" <dianders@chromium.org>
Cc: "'Olof Johansson'" <olof@lixom.net>,
	"'Thomas Abraham'" <thomas.abraham@linaro.org>,
	"'Vivek Gautam'" <gautam.vivek@samsung.com>,
	"'Russell King'" <linux@arm.linux.org.uk>,
	"'Padmavathi Venna'" <padma.v@samsung.com>,
	"'Mark Brown'" <broonie@opensource.wolfsonmicro.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: RE: [PATCH] ARM: dts: add usb 2.0 clock references to exynos5250 device tree
Date: Wed, 03 Apr 2013 10:46:08 +0900	[thread overview]
Message-ID: <24ae01ce300d$037af160$0a70d420$%kim@samsung.com> (raw)
In-Reply-To: <CAFp+6iFXd-4uFfc4v_kWf_FTBmeHkNwsEV0QoyHCzza8evgd9A@mail.gmail.com>

Vivek Gautam wrote:
> 
> Hi,
> 
> 
> On Fri, Mar 15, 2013 at 7:07 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> >
> > On Thursday, March 14, 2013 2:18 AM, Doug Anderson wrote:
> >>
> >> This is a fixup to two device tree nodes that have already landed but
> >> without clock nodes since the transition to common clock happened at
> >> the same time.
> >>
> >> Signed-off-by: Doug Anderson <dianders@chromium.org>
> >
> > The clock number and name are right.
> >
> > Reviewed-by: Jingoo Han <jg1.han@samsung.com>
> >
> >
> > Best regards,
> > Jingoo Han
> >
> >> ---
> >>  arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> >> index 24c52e6..59be603 100644
> >> --- a/arch/arm/boot/dts/exynos5250.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> >> @@ -402,12 +402,18 @@
> >>               compatible = "samsung,exynos4210-ehci";
> >>               reg = <0x12110000 0x100>;
> >>               interrupts = <0 71 0>;
> >> +
> >> +             clocks = <&clock 285>;
> >> +             clock-names = "usbhost";
> >>       };
> >>
> >>       usb@12120000 {
> >>               compatible = "samsung,exynos4210-ohci";
> >>               reg = <0x12120000 0x100>;
> >>               interrupts = <0 71 0>;
> >> +
> >> +             clocks = <&clock 285>;
> >> +             clock-names = "usbhost";
> 
> tested this patch with smdk5250 h/w.
> 
> Tested-by: Vivek Gautam <gautam.vivek@samsung.com>
> 
Vivek and Jingoo,

Thanks for your review and test.

Looks good to me and I applied in my local.
Just note that this should be seen in my public tree tomorrow night(KST).

- Kukjin


      reply	other threads:[~2013-04-03  1:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-13 17:18 Doug Anderson
2013-03-14  6:22 ` Vivek Gautam
2013-03-14 23:01   ` Doug Anderson
2013-03-15  1:37 ` Jingoo Han
2013-03-18 13:41   ` Vivek Gautam
2013-04-03  1:46     ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='24ae01ce300d$037af160$0a70d420$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dianders@chromium.org \
    --cc=gautam.vivek@samsung.com \
    --cc=gautamvivek1987@gmail.com \
    --cc=jg1.han@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=olof@lixom.net \
    --cc=padma.v@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®