From: Reinette Chatre <reinette.chatre@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>, <linux-kernel@vger.kernel.org>
Cc: kernel test robot <lkp@intel.com>,
Vikas Shivappa <vikas.shivappa@linux.intel.com>,
Tony Luck <tony.luck@intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
Fenghua Yu <fenghua.yu@intel.com>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>
Subject: Re: [PATCH] x86/intel_rdt/cqm: fix kernel-doc warnings
Date: Tue, 10 Oct 2023 07:25:44 -0700 [thread overview]
Message-ID: <24af5965-3fe9-4aca-83e0-5981f721253f@intel.com> (raw)
In-Reply-To: <5589e93d-9a9c-4199-a187-ab60fb127236@intel.com>
Hi Randy,
On 10/9/2023 10:07 AM, Reinette Chatre wrote:
> On 10/6/2023 4:51 PM, Randy Dunlap wrote:
>>
>> We don't have a syntax for documenting individual data items via
>> kernel-doc, so remove the "/**" kernel-doc markers and add a hyphen
>> for consistency.
>>
I've been thinking more about this change and I would also
like to propose that you do not use "We" in the commit message.
I understand that you are not impersonating code but I think it
would be simpler to avoid any potential controversy by not using
"We". Perhaps something like "There is no syntax for documenting ...".
Reinette
next prev parent reply other threads:[~2023-10-10 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 23:51 Randy Dunlap
2023-10-08 9:52 ` [tip: x86/urgent] x86/resctrl: Fix " tip-bot2 for Randy Dunlap
2023-10-09 17:07 ` [PATCH] x86/intel_rdt/cqm: fix " Reinette Chatre
2023-10-10 14:25 ` Reinette Chatre [this message]
2023-10-10 15:17 ` Randy Dunlap
2023-10-10 15:24 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24af5965-3fe9-4aca-83e0-5981f721253f@intel.com \
--to=reinette.chatre@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®