From: Stanley Chu <stanley.chu@mediatek.com>
To: Bart Van Assche <bvanassche@acm.org>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<martin.petersen@oracle.com>, <avri.altman@wdc.com>,
<alim.akhtar@samsung.com>, <jejb@linux.ibm.com>
Cc: <peter.wang@mediatek.com>, <chun-hung.wu@mediatek.com>,
<alice.chao@mediatek.com>, <powen.kao@mediatek.com>,
<mason.zhang@mediatek.com>, <qilin.tan@mediatek.com>,
<lin.gui@mediatek.com>, <eddie.huang@mediatek.com>,
<tun-yu.yu@mediatek.com>, <cc.chou@mediatek.com>,
<chaotian.jing@mediatek.com>, <jiajie.hao@mediatek.com>,
Peter Wang <peter.want@medaitek.com>
Subject: Re: [PATCH v3 03/10] scsi: ufs-mediatek: Introduce workaround for power mode change
Date: Wed, 15 Jun 2022 11:49:38 +0800 [thread overview]
Message-ID: <24af9009a288f4bd0ee01f2250a0d746564136ed.camel@mediatek.com> (raw)
In-Reply-To: <386bfd16-e7be-7f80-cbaa-f55e01d3b070@acm.org>
On Tue, 2022-06-14 at 09:46 -0700, Bart Van Assche wrote:
> On 6/14/22 07:16, Stanley Chu wrote:
> > + if ((dev_req_params->pwr_tx != FAST_MODE) &&
> > + (dev_req_params->gear_tx < UFS_HS_G4))
> > + return false;
> > +
> > + if ((dev_req_params->pwr_rx != FAST_MODE) &&
> > + (dev_req_params->gear_rx < UFS_HS_G4))
> > + return false;
>
> Please do not use more parentheses than needed. I think 8
> parentheses
> can be left out from the above code.
Thanks! fixed in v4.
>
> Thanks,
>
> Bart.
next prev parent reply other threads:[~2022-06-15 3:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 14:16 [PATCH v3 00/10] scsi: ufs: Fix PMC and low-power mode on MediaTek UFS platforms Stanley Chu
2022-06-14 14:16 ` [PATCH v3 01/10] scsi: ufs: Export ufshcd_uic_change_pwr_mode() Stanley Chu
2022-06-14 14:16 ` [PATCH v3 02/10] scsi: ufs: Fix ADAPT logic for HS-G5 Stanley Chu
2022-06-14 14:16 ` [PATCH v3 03/10] scsi: ufs-mediatek: Introduce workaround for power mode change Stanley Chu
2022-06-14 16:46 ` Bart Van Assche
2022-06-15 3:49 ` Stanley Chu [this message]
2022-06-14 14:16 ` [PATCH v3 04/10] scsi: ufs-mediatek: Fix the timing of configuring device regulators Stanley Chu
2022-06-14 16:33 ` Bart Van Assche
2022-06-15 3:49 ` Stanley Chu
2022-06-14 14:16 ` [PATCH v3 05/10] scsi: ufs-mediatek: Prevent device regulators setting as LPM incorrectly Stanley Chu
2022-06-14 14:16 ` [PATCH v3 06/10] scsi: ufs-mediatek: Support low-power mode for VCCQ Stanley Chu
2022-06-14 14:16 ` [PATCH v3 07/10] scsi: ufs-mediatek: Support flexible parameters for smc calls Stanley Chu
2022-06-14 16:28 ` Bart Van Assche
2022-06-15 3:48 ` Stanley Chu
2022-06-14 14:16 ` [PATCH v3 08/10] scsi: ufs-mediatek: Support low-power mode for parents of VCCQx Stanley Chu
2022-06-14 14:16 ` [PATCH v3 09/10] scsi: ufs: Export regulator functions Stanley Chu
2022-06-14 14:16 ` [PATCH v3 10/10] scsi: ufs-mediatek: Support multiple VCC sources Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24af9009a288f4bd0ee01f2250a0d746564136ed.camel@mediatek.com \
--to=stanley.chu@mediatek.com \
--cc=alice.chao@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mason.zhang@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=peter.want@medaitek.com \
--cc=powen.kao@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=tun-yu.yu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®