From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752764AbdK3QRV (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 11:17:21 -0500
Received: from mail-pg0-f54.google.com ([74.125.83.54]:40661 "EHLO
        mail-pg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751349AbdK3QRU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 11:17:20 -0500
X-Google-Smtp-Source: AGs4zMb1pc4G86WGqxH12RKlw0ooIFzMYsBeT5oOlDddiUqCHsqVK2Cfso8V0jATLe4HMR6bfiKBqw==
Subject: Re: [PATCH net-next 3/5] bpftool: implement cgattach command
To: Roman Gushchin <guro@fb.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
        daniel@iogearbox.net, jakub.kicinski@netronome.com, kafai@fb.com
References: <20171130134302.2840-1-guro@fb.com>
 <20171130134302.2840-4-guro@fb.com>
From: David Ahern <dsahern@gmail.com>
Message-ID: <24b1be13-0f42-7695-7b06-7236b2c0beeb@gmail.com>
Date: Thu, 30 Nov 2017 09:17:17 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171130134302.2840-4-guro@fb.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/30/17 6:43 AM, Roman Gushchin wrote:
> @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv)
>  	fprintf(stderr,
>  		"Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n"
>  		"       %s batch file FILE\n"
> +		"       %s cgattach FILE CGROUP TYPE\n"

Can you change the order to:
+		"       %s cgattach CGROUP TYPE FILE\n"

Makes for better consistency with the detach command in the next patch:
+		"       %s cgdetach CGROUP TYPE ID\n"