From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC18C433EF for ; Mon, 18 Apr 2022 19:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347689AbiDRTZW (ORCPT ); Mon, 18 Apr 2022 15:25:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236893AbiDRTZT (ORCPT ); Mon, 18 Apr 2022 15:25:19 -0400 Received: from relay3.hostedemail.com (relay3.hostedemail.com [64.99.140.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0DD732EFB for ; Mon, 18 Apr 2022 12:22:39 -0700 (PDT) Received: from omf12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9EE6D2466A; Mon, 18 Apr 2022 19:22:38 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id 6EC2619; Mon, 18 Apr 2022 19:22:37 +0000 (UTC) Message-ID: <24b3a1f5c1fa416ac5aed375afaa03c0c3ce2be1.camel@perches.com> Subject: Re: [PATCH] staging: media: av7110: remove redundant space after cast From: Joe Perches To: Aliya Rahmani , mchehab@kernel.org Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, outreachy@lists.linux.dev, linux-kernel@vger.kernel.org Date: Mon, 18 Apr 2022 12:22:36 -0700 In-Reply-To: <20220418170900.16725-1-aliyarahmani786@gmail.com> References: <20220418170900.16725-1-aliyarahmani786@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Stat-Signature: ta1pnoj6dj87sbrqzcmi6i5ozqoac1o5 X-Rspamd-Server: rspamout03 X-Rspamd-Queue-Id: 6EC2619 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX19umMeH10kJGQ1Ot4hgxrCHJcCqVxKTlfg= X-HE-Tag: 1650309757-686062 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2022-04-18 at 22:39 +0530, Aliya Rahmani wrote: > Remove the unnecessary space immediately after a cast. Identified by > checkpatch: CHECK: No space is necessary after a cast. [] > diff --git a/drivers/staging/media/av7110/av7110_av.c b/drivers/staging/media/av7110/av7110_av.c [] > @@ -93,7 +93,7 @@ int av7110_record_cb(struct dvb_filter_pes2ts *p2t, u8 *buf, size_t len) > > static int dvb_filter_pes2ts_cb(void *priv, unsigned char *data) > { > - struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *) priv; > + struct dvb_demux_feed *dvbdmxfeed = (struct dvb_demux_feed *)priv; It's also unnecessary to cast void pointers so the cast could be removed. struct dvb_demux_feed *dvbdmxfeed = priv; And the code here uses dvbdmxfeed and feed rather interchangeably for uses of a struct dvb_demux_feed *. It might be better just to use feed and change the other uses too. Do consider this just a coding exercise as the driver is for some hardware that is effectively dead/unavailable/non-functional. Look at: commit 989cf18ed08f8b6efd1d1592d1d0108fa09b98f5 Author: Mauro Carvalho Chehab Date: Mon May 31 17:27:09 2021 +0200 media: av7110: move driver to staging This driver is really old, from devices that aren't manufactured anymore for more than a decade. Maybe instead consider adding a MAINTAINERS section suggesting this is obsolete and/or a TODO entry in this directory saying "Delete this" after some time.